From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6A08C433FE for ; Mon, 18 Oct 2021 12:17:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC9A660FC3 for ; Mon, 18 Oct 2021 12:17:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231495AbhJRMTp (ORCPT ); Mon, 18 Oct 2021 08:19:45 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:33537 "EHLO wout2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbhJRMTo (ORCPT ); Mon, 18 Oct 2021 08:19:44 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id C5B203200FA2; Mon, 18 Oct 2021 08:17:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 18 Oct 2021 08:17:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=x0KJzCbJFSe9C/yj3j/2aCCzcsO x35f4682NnWdDluM=; b=sv+KtCGoqPyFXurcu/jhFUUGEPCC8ADKapb/x3ENyqW 2nwWr5Aqhpj6lelCO3nJiEA2iqQrutJIMgAY5b/gbWwCJ7979rYAytlc9i8MJxm7 ptLG+Q6uKlSMug+OBT53gfqlRx5WhLIV1lspdJULCTR8UzJCuT7QlV446o69dIxn c+7hkSMEYQhhRNrdQJHYvc6BRzJ06fpECnoKQnT+6WzEEJt51KiXdG3/uB3W582g LVuux3noxAXGNqycqJ68jfFIcKyO6MjCIjtD1202QTs+C9P7G2kXxL7ONEsJqZ6s UoI86VD/+ZSCuA03m4A1sPTt4mAsDaaYLE9P+GEzFtQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=x0KJzC bJFSe9C/yj3j/2aCCzcsOx35f4682NnWdDluM=; b=SZUPvv8fYnOJVLiYv1jfnJ HzgHCWzjAlewIb5eFz4lcg4/jW/IfTauwFQnMs9j1FP7YXsgd9QHbZHQn/Geq/hy gqXwLIGBeXdgyS9O4k+14ms6yNXmztB0rwWDwlN8YHKooRyoXQOW2JWH8SJ5bvip ktKNHLIzLgjNf1RvswLGiGrGou24w65mLa/ea8R5HJcm4ryT+LwffKLTjXPYhj5w AorHgk/tuF1QCfxZqm5FvRQ/QpmD5Ej4KyY4BCmY6pyP5El/f6mnpTvRuNpa1bA9 vlxCrsTCoE0eQiENC+8NM9Beh1w0DtCmYQRbsdHbOO+D0UjruaLf/qk9BEbvF8bA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvtddggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefvrghkrghs hhhiucfurghkrghmohhtohcuoehoqdhtrghkrghshhhisehsrghkrghmohgttghhihdrjh hpqeenucggtffrrghtthgvrhhnpeejgeeifeeuveeufeeigeegjeelvdfgjeegffejgfdv keelhefgtdefteejleekjeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepohdqthgrkhgrshhh ihesshgrkhgrmhhotggthhhirdhjph X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Oct 2021 08:17:28 -0400 (EDT) Date: Mon, 18 Oct 2021 21:17:25 +0900 From: Takashi Sakamoto To: Takashi Iwai Cc: alsa-devel@alsa-project.org, Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: firewire: Fix C++ style comments in uapi header Message-ID: Mail-Followup-To: Takashi Iwai , alsa-devel@alsa-project.org, Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211018063700.30834-1-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211018063700.30834-1-tiwai@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Oct 18, 2021 at 08:37:00AM +0200, Takashi Iwai wrote: > UAPI headers are built with -std=c90 and C++ style comments are > explicitly prohibited. The recent commit overlooked the rule and > caused the error at header installation. This patch corrects those. > > Fixes: bea36afa102e ("ALSA: firewire-motu: add message parser to gather meter information in register DSP model") > Fixes: 90b28f3bb85c ("ALSA: firewire-motu: add message parser for meter information in command DSP model") > Fixes: 634ec0b2906e ("ALSA: firewire-motu: notify event for parameter change in register DSP model") > Reported-by: Stephen Rothwell > Link: https://lore.kernel.org/r/20211018113812.0a16efb0@canb.auug.org.au > Signed-off-by: Takashi Iwai > --- > include/uapi/sound/firewire.h | 70 ++++++++++++++++++----------------- > 1 file changed, 37 insertions(+), 33 deletions(-) I completely overlooked it. Thanks for your reporting. Acked-by: Takashi Sakamoto Regards Takashi Sakamoto