From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 558E1C433F5 for ; Mon, 18 Oct 2021 14:52:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 357C760F57 for ; Mon, 18 Oct 2021 14:52:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232562AbhJROyZ (ORCPT ); Mon, 18 Oct 2021 10:54:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:39486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232517AbhJROyX (ORCPT ); Mon, 18 Oct 2021 10:54:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9CC0560F57; Mon, 18 Oct 2021 14:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634568732; bh=Uu2xD4xBBeduHjiG1sJuamGYPkQaDrVSpnSNLYkmafg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NB12N1xiso6lDaOdPqAAUDzhaj8NrEn0cQN2x1m0tEt60u3Y/43IvmFysafxJgHde 5OSNPOzGKQ3Fs0meTdxvWEzHw1vLPo+2pOLeBRgSkW0V37vcrJihzPy1UlEOu35dGT aJrpKdEykMjbPNKDTFyOVv0Ez6w9ArsxwG9H3cPg= Date: Mon, 18 Oct 2021 16:52:09 +0200 From: Greg Kroah-Hartman To: Michael Straube Cc: Martin Kaiser , Larry Finger , Phillip Potter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] staging: r8188eu: Makefile: don't overwrite global settings Message-ID: References: <20211016173544.25376-1-martin@kaiser.cx> <20211016173544.25376-3-martin@kaiser.cx> <20211017174621.dkunl2xhjg4yn2at@viti.kaiser.cx> <54987f44-cabf-c12c-ae3b-341ff6b1ed98@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54987f44-cabf-c12c-ae3b-341ff6b1ed98@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 17, 2021 at 10:46:11PM +0200, Michael Straube wrote: > On 10/17/21 19:46, Martin Kaiser wrote: > > Thus wrote Michael Straube (straube.linux@gmail.com): > > > > > On 10/16/21 19:35, Martin Kaiser wrote: > > > > Remove settings from the Makefile that are set by higher-level Makefiles. > > > > > > Some of those settings might have been useful when the driver was > > > > maintained out of tree. > > > > > > Signed-off-by: Martin Kaiser > > > > --- > > > > drivers/staging/r8188eu/Makefile | 14 -------------- > > > > 1 file changed, 14 deletions(-) > > > > > > diff --git a/drivers/staging/r8188eu/Makefile b/drivers/staging/r8188eu/Makefile > > > > index fccf7e6d1520..8294fb69ecf9 100644 > > > > --- a/drivers/staging/r8188eu/Makefile > > > > +++ b/drivers/staging/r8188eu/Makefile > > > > @@ -1,8 +1,3 @@ > > > > -SHELL := /bin/bash > > > > -EXTRA_CFLAGS += $(USER_EXTRA_CFLAGS) > > > > -EXTRA_CFLAGS += -O1 > > > > - > > > > -ccflags-y += -D__CHECK_ENDIAN__ > > > > OUTSRC_FILES := \ > > > > hal/HalHWImg8188E_MAC.o \ > > > > @@ -46,15 +41,6 @@ _OS_INTFS_FILES := \ > > > > _HAL_INTFS_FILES += $(OUTSRC_FILES) > > > > -SUBARCH := $(shell uname -m | sed -e "s/i.86/i386/; s/ppc.*/powerpc/; s/armv.l/arm/; s/aarch64/arm64/;") > > > > - > > > > -ARCH ?= $(SUBARCH) > > > > -CROSS_COMPILE ?= > > > > -KVER ?= $(if $(KERNELRELEASE),$(KERNELRELEASE),$(shell uname -r)) > > > > -KSRC ?= $(if $(KERNEL_SRC),$(KERNEL_SRC),/lib/modules/$(KVER)/build) > > > > -MODDESTDIR := /lib/modules/$(KVER)/kernel/drivers/net/wireless > > > > -INSTALL_PREFIX := > > > > - > > > > rtk_core := \ > > > > core/rtw_ap.o \ > > > > core/rtw_br_ext.o \ > > > > > > > Hi Martin, this patch introduces a GCC warning on my system. > > > > > drivers/staging/r8188eu/os_dep/ioctl_linux.c: In function > > > 'rtw_wx_set_enc_ext': > > > drivers/staging/r8188eu/os_dep/ioctl_linux.c:1929:9: warning: 'strncpy' > > > specified bound 16 equals destination size [-Wstringop-truncation] > > > 1929 | strncpy((char *)param->u.crypt.alg, alg_name, > > > IEEE_CRYPT_ALG_NAME_LEN); > > > | > > > > > > Hi Michael, > > > > thanks for reporting this. So far, I can't reproduce the warning, even > > if I enable -Wstringop-truncation explicitly. I tried this with gcc > > 8.3.0 (Debian buster) on x86_64. > > Hi Martin, > > probably only newer gcc versions produce this warning. On my system > the gcc version is 11.2.1 (openSUSE Tumbleweed). I have gcc 11.1.0 here and I can not duplicate this warning. And it looks like the code matches other places in the kernel where this happens, so I'll just take this for now and see if someone wants to send me a real fix for it, as it is independent of this Makefile change. thanks, greg k-h