From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
dave.hansen@linux.intel.com, x86@kernel.org,
yang.zhong@intel.com, jarkko@kernel.org, bp@suse.de
Subject: Re: [PATCH v3 2/2] x86: sgx_vepc: implement SGX_IOC_VEPC_REMOVE ioctl
Date: Mon, 18 Oct 2021 17:47:26 +0000 [thread overview]
Message-ID: <YW2zLoFCq4l2w4p6@google.com> (raw)
In-Reply-To: <e9af2f2e-a0cf-1916-c960-2a663e6f4596@redhat.com>
On Mon, Oct 18, 2021, Paolo Bonzini wrote:
> On 18/10/21 19:17, Sean Christopherson wrote:
> > /*
> > * Report errors due to #GP or SGX_ENCLAVE_ACT, but do
> > * not WARN as userspace can induce said failures by
> > * calling the ioctl concurrently on multiple vEPCs or
> > * while one or more CPUs is running the enclave. Only
> > * a #PF on EREMOVE indicates a kernel/hardware issue.
> > */
> > WARN_ON_ONCE(encls_faulted(ret) &&
> > ENCLS_TRAPNR(ret) == X86_TRAP_PF);
>
> or != X86_TRAP_GP, just to avoid having a v5? :)
LOL, good point, that's indeed better.
next prev parent reply other threads:[~2021-10-18 17:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 7:14 [PATCH v3 0/2] x86: sgx_vepc: implement ioctl to EREMOVE all pages Paolo Bonzini
2021-10-16 7:14 ` [PATCH v3 1/2] x86: sgx_vepc: extract sgx_vepc_remove_page Paolo Bonzini
2021-10-16 7:14 ` [PATCH v3 2/2] x86: sgx_vepc: implement SGX_IOC_VEPC_REMOVE ioctl Paolo Bonzini
2021-10-18 17:17 ` Sean Christopherson
2021-10-18 17:45 ` Paolo Bonzini
2021-10-18 17:47 ` Sean Christopherson [this message]
2021-10-18 12:51 ` [PATCH v3 0/2] x86: sgx_vepc: implement ioctl to EREMOVE all pages Jarkko Sakkinen
2021-10-18 13:03 ` Paolo Bonzini
2021-10-18 13:28 ` Jarkko Sakkinen
2021-10-18 12:58 ` Borislav Petkov
2021-10-19 10:17 ` Yang Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW2zLoFCq4l2w4p6@google.com \
--to=seanjc@google.com \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=x86@kernel.org \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox