public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	linux-realtek-soc@lists.infradead.org,
	Oder Chiou <oder_chiou@realtek.com>,
	Ping-Ke Shih <pkshih@realtek.com>,
	nic_swsd@realtek.com, Derek Fang <derek.fang@realtek.com>,
	Hayes Wang <hayeswang@realtek.com>,
	Kailang Yang <kailang@realtek.com>,
	linux-iio <linux-iio@vger.kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	LKML <linux-kernel@vger.kernel.org>,
	info@ayaneo.com
Subject: Re: BMI160 accelerometer on AyaNeo tablet
Date: Mon, 18 Oct 2021 22:02:04 +0300	[thread overview]
Message-ID: <YW3ErLKGtmyhSFd3@smile.fi.intel.com> (raw)
In-Reply-To: <CACAwPwaj_ekK6j9S4CRu6tRTPyjffgDhL3UFnhoYSyJSkAkmpw@mail.gmail.com>

On Mon, Oct 18, 2021 at 09:02:40PM +0300, Maxim Levitsky wrote:
> I also suspect a mistake from the hardware vendors.
> 
> I attached all DSDT decompiled, which shows that they indeed use that
> ID, and I also attached the windows driver .INF which was published on
> their website  with the driver (https://www.ayaneo.com/downloads)
> 
> They are a small startup so they might have used the realtek ID by mistake.
> I added them to the CC.

Thank you for sharing. Seems they indeed used (deliberately or not) the wrong
ID. So there are questions I have:
- Is the firmware available in the wild?
- Do they plan to update firmware to fix this?
- Can we make sure that guys got their mistake and will be more careful
  in the future?

Realtek probably should make this ID marked somehow broken and not use
in their products in case the answer to the first of the above question
is "yes". (Of course in case the ID will be used for solely PCI enumerated
product there will be no conflict, I just propose to be on the safest side,
but remark should be made somewhere).

> BTW, I also notice a rotation matrix embedded in DSTD, but the linux's
> BMI160 driver doesn't recognize it.

This is done by the commit 8a0672003421 ("iio: accel: bmc150: Get
mount-matrix from ACPI") which needs to be amended to take care about
more devices, somewhere in drivers/iio/industialio-acpi.c ? Jonathan,
Hans, what do you think?

P.S. As I said, the commit message and the code (in the comments) should
be very well elaborated and only accepted in case the firmware is already
in the wild on the market.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2021-10-18 19:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CACAwPwb7edLzX-KO1XVNWuQ3w=U0BfA=_kwiGCjZOpKfZpc2pw@mail.gmail.com>
2021-10-16 16:27 ` BMI160 accelerometer on AyaNeo tablet Maxim Levitsky
2021-10-17 10:58   ` Jonathan Cameron
2021-10-18  7:40     ` Andy Shevchenko
2021-10-18 15:17       ` Jonathan Cameron
2021-10-18 15:22         ` Andy Shevchenko
2021-10-18 15:30   ` Andy Shevchenko
2021-10-18 18:02     ` Maxim Levitsky
2021-10-18 19:02       ` Andy Shevchenko [this message]
2021-10-18 20:42         ` Maxim Levitsky
2021-10-19  9:58           ` Andy Shevchenko
2021-10-19 16:29             ` Maxim Levitsky
2021-10-20  2:31             ` Hayes Wang
2021-10-20 17:37             ` Jonathan Cameron
2021-10-20 20:03               ` Andy Shevchenko
2021-10-19  8:10         ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YW3ErLKGtmyhSFd3@smile.fi.intel.com \
    --to=andy.shevchenko@gmail.com \
    --cc=derek.fang@realtek.com \
    --cc=hayeswang@realtek.com \
    --cc=hdegoede@redhat.com \
    --cc=info@ayaneo.com \
    --cc=kailang@realtek.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-realtek-soc@lists.infradead.org \
    --cc=maximlevitsky@gmail.com \
    --cc=nic_swsd@realtek.com \
    --cc=oder_chiou@realtek.com \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox