From: Andrew Lunn <andrew@lunn.ch>
To: Erik Ekman <erik@kryo.se>
Cc: Edward Cree <ecree.xilinx@gmail.com>,
Martin Habets <habetsm.xilinx@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sfc: Export fibre-specific link modes for 1/10G
Date: Tue, 19 Oct 2021 17:31:52 +0200 [thread overview]
Message-ID: <YW7k6JVh5LxMNP98@lunn.ch> (raw)
In-Reply-To: <20211018183709.124744-1-erik@kryo.se>
On Mon, Oct 18, 2021 at 08:37:08PM +0200, Erik Ekman wrote:
> These modes were added to ethtool.h in 5711a98221443 ("net: ethtool: add support
> for 1000BaseX and missing 10G link modes") back in 2016.
>
> Only setting CR mode for 10G, similar to how 25/40/50/100G modes are set up.
>
> Tested using SFN5122F-R7 (with 2 SFP+ ports) and a 1000BASE-BX10 SFP module.
Did you test with a Copper SFP modules?
> +++ b/drivers/net/ethernet/sfc/mcdi_port_common.c
> @@ -133,9 +133,9 @@ void mcdi_to_ethtool_linkset(u32 media, u32 cap, unsigned long *linkset)
> case MC_CMD_MEDIA_QSFP_PLUS:
> SET_BIT(FIBRE);
> if (cap & (1 << MC_CMD_PHY_CAP_1000FDX_LBN))
> - SET_BIT(1000baseT_Full);
> + SET_BIT(1000baseX_Full);
I'm wondering if you should have both? The MAC is doing 1000BaseX. But
it could then be connected to a copper PHY which then does
1000baseT_Full? At 1G, it is however more likely to be using SGMII,
not 1000BaseX.
Andrew
next prev parent reply other threads:[~2021-10-19 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 18:37 [PATCH] sfc: Export fibre-specific link modes for 1/10G Erik Ekman
2021-10-19 15:31 ` Andrew Lunn [this message]
2021-10-19 19:18 ` Martin Habets
2021-10-19 20:09 ` Erik Ekman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW7k6JVh5LxMNP98@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=erik@kryo.se \
--cc=habetsm.xilinx@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox