From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org,
Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] rtc: s3c: Add time range
Date: Tue, 19 Oct 2021 23:04:47 +0200 [thread overview]
Message-ID: <YW8y73hydUFeSBzj@piout.net> (raw)
In-Reply-To: <CAPLW+4k26qZDug4JkuPaM_gZMgz8LPg7GHe-5C7zKzEGtzdp=g@mail.gmail.com>
On 19/10/2021 22:12:09+0300, Sam Protsenko wrote:
> > It would be better to pass the proper values because else nobody will
> > ever come back and fix it (hence why I didn't move that driver to
> > devm_rtc_register_device yet).
> >
>
> Krzysztof, do you have by chance the doc for different SoCs supported
> by S3C RTC driver? I can implement proper values for min/max range for
> each SoC, as Alexandre asked, by adding those to driver data. But I
> need max year register value (100, 1000, etc) for each of those chips:
>
> - "samsung,s3c2410-rtc"
> - "samsung,s3c2416-rtc"
> - "samsung,s3c2443-rtc"
> - "samsung,s3c6410-rtc"
> - "samsung,exynos3250-rtc"
>
> For example Exynos850 TRM states that BCDYEAR register has [11:0] bits
> for holding the year value in BCD format, so it's 10^(12/4)=1000 years
> max.
>
And the question will be whether time is contiguous over this period. A
very common thing is that the RTC will think that years divisible by 100
are not leap years, even if the register accepts higher values. This
makes it work for 2000 but fails in 2100.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-10-19 21:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 13:17 [PATCH 0/4] rtc: s3c: S3C driver improvements Sam Protsenko
2021-10-19 13:17 ` [PATCH 1/4] rtc: s3c: Remove usage of devm_rtc_device_register() Sam Protsenko
2021-10-19 16:11 ` Krzysztof Kozlowski
2021-10-19 13:17 ` [PATCH 2/4] rtc: s3c: Add time range Sam Protsenko
2021-10-19 16:17 ` Krzysztof Kozlowski
2021-10-19 16:22 ` Krzysztof Kozlowski
2021-10-19 16:35 ` Sam Protsenko
2021-10-19 17:48 ` Alexandre Belloni
2021-10-19 19:12 ` Sam Protsenko
2021-10-19 21:04 ` Alexandre Belloni [this message]
2021-10-20 6:29 ` Krzysztof Kozlowski
2021-10-21 19:48 ` Sam Protsenko
2021-10-21 20:55 ` Alexandre Belloni
2021-10-19 16:20 ` Alexandre Belloni
2021-10-19 16:31 ` Sam Protsenko
2021-10-19 17:46 ` Alexandre Belloni
2021-10-19 13:17 ` [PATCH 3/4] rtc: s3c: Extract read/write IO into separate functions Sam Protsenko
2021-10-19 16:24 ` Krzysztof Kozlowski
2021-10-19 13:17 ` [PATCH 4/4] rtc: s3c: Fix RTC read on first boot Sam Protsenko
2021-10-19 15:48 ` Alexandre Belloni
2021-10-19 16:04 ` Sam Protsenko
2021-10-19 16:19 ` Krzysztof Kozlowski
2021-10-19 16:10 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW8y73hydUFeSBzj@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox