From: Sean Christopherson <seanjc@google.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Reiji Watanabe <reijiw@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org,
syzbot <syzbot+9fc046ab2b0cf295a063@syzkaller.appspotmail.com>
Subject: Re: [syzbot] WARNING in static_key_slow_try_dec (2)
Date: Tue, 12 Oct 2021 16:37:28 +0000 [thread overview]
Message-ID: <YWW5yN5OCSjRXptm@google.com> (raw)
In-Reply-To: <YWWqG3xF6KAHBU2O@google.com>
On Tue, Oct 12, 2021, Sean Christopherson wrote:
> On Sun, Oct 10, 2021, Tetsuo Handa wrote:
> > Hello.
> >
> > Commit 4547700a4d190ac4 ("KVM: x86: Consolidate APIC base RESET initialization code")
>
> That's definitely where the error was made visible,
I take that back, the bug was likely visible even before the redundant vendor code
was dropped. Doesn't change the fix in any way though.
> but commit 421221234ada ("KVM: x86: Open code necessary bits of
> kvm_lapic_set_base() at vCPU RESET") is the real culprit. I'll send a patch
> later today. I'm leaning toward a partial revert with some extra comments.
>
> Thanks for the debug! I was having trouble reproducing the syzbot report.
prev parent reply other threads:[~2021-10-12 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 17:27 [syzbot] WARNING in static_key_slow_try_dec (2) syzbot
2021-10-10 5:34 ` Tetsuo Handa
2021-10-12 15:30 ` Sean Christopherson
2021-10-12 16:37 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWW5yN5OCSjRXptm@google.com \
--to=seanjc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=reijiw@google.com \
--cc=syzbot+9fc046ab2b0cf295a063@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox