From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C051C433F5 for ; Tue, 12 Oct 2021 18:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 251A960C40 for ; Tue, 12 Oct 2021 18:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234155AbhJLShO (ORCPT ); Tue, 12 Oct 2021 14:37:14 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:41784 "EHLO mail-wr1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233972AbhJLShM (ORCPT ); Tue, 12 Oct 2021 14:37:12 -0400 Received: by mail-wr1-f44.google.com with SMTP id t2so206117wrb.8 for ; Tue, 12 Oct 2021 11:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+MzK5n1Jhif+mQxJnLglldcWXS1nPzxCkrew0qXtEOU=; b=qn1yIPH7igXgUYvJyNf+lMA5Na1WkDrCtZvVkXDSLw3RYsheB/SjL7h3oe/8VfJRM6 swQ+pEZhKhXRLK0J7GjaKAw8HyX4RQL9VuhdDJTaw8WEEoFtv3LceihfxBKTEDW1wWlC sq9V5PZjA8G/NC1fEC2w00TP3lC+KxQbc7SSQhuj568escPq5duCyLxSNuCPu0umt3bs YfDykx8uhUghunO2sbCrnjf+oXClI/6o6kZHLmFv3fSsihcvO2EQKE2JcwNHjRoR6yjz e2QWFe5SRnH8cPWNhSD2oK2Xaj6RJsh4PJQqiZPF1BnGyCgSFE3qZOWMQfT9+yo4rqMt yGIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+MzK5n1Jhif+mQxJnLglldcWXS1nPzxCkrew0qXtEOU=; b=NRhBMmdulvy7jWdXKiVpOsTbCtnaGOvd/eaZ2YNcL3yxRc36LYZBPEqRuIbfg83Y+u KgVotamZ9nHfZI1fI27psfn6Ck77+G3vHcfTET/1qYaxwSA3s5ayRiAQA4WHGGurG646 MZdOYb93uwn1z5HrmI7ReNeI72EvFVSSwU7wH1K1HsU/X0OjOPgn+cBySVoNCrczu7x+ U+YV6ESN2a/wSS/s5J7xOLTcVxj3UlSJJPx/wWByE+jLSMXnVyNcc4c5jXBsYt70fEa6 pKrIm2kSF5bxa9LSjwim7ZauHEKRzXFOasI0qHmuoHSxv7+JkGHcZ9IjSyCQVOvqn8TA 0gdA== X-Gm-Message-State: AOAM5301Q8bvLZeMB9ya7PbbIze5hvv9hamJyf5L1ahL6+jOVWUPqtIj iKiclQQG1bvsQIV+cTJFK09b7A== X-Google-Smtp-Source: ABdhPJzE2frHKu4EaDqt6/zHRBoiXTrb/eEMPkovNnZJcaC+XoHGHrBMDZtJYnqBgCnZDk55XC5iow== X-Received: by 2002:a7b:c4c8:: with SMTP id g8mr7525574wmk.101.1634063611193; Tue, 12 Oct 2021 11:33:31 -0700 (PDT) Received: from google.com ([95.148.6.175]) by smtp.gmail.com with ESMTPSA id c7sm4759799wmq.13.2021.10.12.11.33.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 11:33:30 -0700 (PDT) Date: Tue, 12 Oct 2021 19:33:28 +0100 From: Lee Jones To: Bjorn Andersson Cc: Andy Gross , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding Message-ID: References: <20211005024812.2038249-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Oct 2021, Bjorn Andersson wrote: > On Tue 12 Oct 09:46 CDT 2021, Lee Jones wrote: > > > On Mon, 04 Oct 2021, Bjorn Andersson wrote: > > > > > Update the binding with eitght more SPMI PMIC compatibles found in the > > > > Spell check. > > > > Bummer... > > > > PMIC info list in the Qualcomm socinfo driver. > > > > > > Signed-off-by: Bjorn Andersson > > > --- > > > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > > > index 5ef79bf3d035..1d2b5f067556 100644 > > > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > > > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > > > @@ -29,6 +29,8 @@ Required properties: > > > "qcom,pm8916", > > > "qcom,pm8004", > > > "qcom,pm8909", > > > + "qcom,pm8028", > > > + "qcom,pm8901", > > > "qcom,pm8950", > > > "qcom,pmi8950", > > > "qcom,pm8998", > > > @@ -38,6 +40,12 @@ Required properties: > > > "qcom,pmk8350", > > > "qcom,pm7325", > > > "qcom,pmr735a", > > > + "qcom,pm8150", > > > + "qcom,pm8150l", > > > + "qcom,pm8150b", > > > + "qcom,pmk8002", > > > + "qcom,pm8150c", > > > + "qcom,smb2351", > > > or generalized "qcom,spmi-pmic". > > > - reg: Specifies the SPMI USID slave address for this device. > > > For more information see: > > > > Is there any reason why these can't be in lexicographical order? > > > > Definitely not, both this list and the list compatible list in the > driver would be better of sorted. I just didn't want to sort and add the > entries in a single commit. > > Do you want me to respin this, adding two patches that sort the > elements? Or will you fix my awesome spelling of 8 above and I send you > the patches that shuffles the entries? If you can fix the spelling and send the whole set, I'll apply it in one go. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog