* [PATCH] iommu/dart: use kmemdup instead of kzalloc and memcpy
@ 2021-10-13 6:34 Wan Jiabing
2021-10-13 12:51 ` Alyssa Rosenzweig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wan Jiabing @ 2021-10-13 6:34 UTC (permalink / raw)
To: Sven Peter, Alyssa Rosenzweig, Joerg Roedel, Will Deacon, iommu,
linux-kernel
Cc: kael_w, Wan Jiabing
Fix following coccicheck warning:
drivers/iommu/apple-dart.c:704:20-27: WARNING opportunity for kmemdup
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/iommu/apple-dart.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
index 280ff8df728d..5eeb8d6b72e2 100644
--- a/drivers/iommu/apple-dart.c
+++ b/drivers/iommu/apple-dart.c
@@ -701,13 +701,12 @@ static struct iommu_group *apple_dart_device_group(struct device *dev)
if (!group)
goto out;
- group_master_cfg = kzalloc(sizeof(*group_master_cfg), GFP_KERNEL);
+ group_master_cfg = kmemdup(cfg, sizeof(*group_master_cfg), GFP_KERNEL);
if (!group_master_cfg) {
iommu_group_put(group);
goto out;
}
- memcpy(group_master_cfg, cfg, sizeof(*group_master_cfg));
iommu_group_set_iommudata(group, group_master_cfg,
apple_dart_release_group);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iommu/dart: use kmemdup instead of kzalloc and memcpy
2021-10-13 6:34 [PATCH] iommu/dart: use kmemdup instead of kzalloc and memcpy Wan Jiabing
@ 2021-10-13 12:51 ` Alyssa Rosenzweig
2021-10-16 14:27 ` Sven Peter
2021-10-18 11:36 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Alyssa Rosenzweig @ 2021-10-13 12:51 UTC (permalink / raw)
To: Wan Jiabing
Cc: Sven Peter, Joerg Roedel, Will Deacon, iommu, linux-kernel,
kael_w
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
On Wed, Oct 13, 2021 at 02:34:41AM -0400, Wan Jiabing wrote:
> Fix following coccicheck warning:
> drivers/iommu/apple-dart.c:704:20-27: WARNING opportunity for kmemdup
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/iommu/apple-dart.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
> index 280ff8df728d..5eeb8d6b72e2 100644
> --- a/drivers/iommu/apple-dart.c
> +++ b/drivers/iommu/apple-dart.c
> @@ -701,13 +701,12 @@ static struct iommu_group *apple_dart_device_group(struct device *dev)
> if (!group)
> goto out;
>
> - group_master_cfg = kzalloc(sizeof(*group_master_cfg), GFP_KERNEL);
> + group_master_cfg = kmemdup(cfg, sizeof(*group_master_cfg), GFP_KERNEL);
> if (!group_master_cfg) {
> iommu_group_put(group);
> goto out;
> }
>
> - memcpy(group_master_cfg, cfg, sizeof(*group_master_cfg));
> iommu_group_set_iommudata(group, group_master_cfg,
> apple_dart_release_group);
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iommu/dart: use kmemdup instead of kzalloc and memcpy
2021-10-13 6:34 [PATCH] iommu/dart: use kmemdup instead of kzalloc and memcpy Wan Jiabing
2021-10-13 12:51 ` Alyssa Rosenzweig
@ 2021-10-16 14:27 ` Sven Peter
2021-10-18 11:36 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Sven Peter @ 2021-10-16 14:27 UTC (permalink / raw)
To: Wan Jiabing, Alyssa Rosenzweig, Joerg Roedel, Will Deacon, iommu,
linux-kernel
Cc: kael_w
On Wed, Oct 13, 2021, at 08:34, Wan Jiabing wrote:
> Fix following coccicheck warning:
> drivers/iommu/apple-dart.c:704:20-27: WARNING opportunity for kmemdup
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/iommu/apple-dart.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Looks good to me, thanks!
Acked-by: Sven Peter <sven@svenpeter.dev>
Sven
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iommu/dart: use kmemdup instead of kzalloc and memcpy
2021-10-13 6:34 [PATCH] iommu/dart: use kmemdup instead of kzalloc and memcpy Wan Jiabing
2021-10-13 12:51 ` Alyssa Rosenzweig
2021-10-16 14:27 ` Sven Peter
@ 2021-10-18 11:36 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Joerg Roedel @ 2021-10-18 11:36 UTC (permalink / raw)
To: Wan Jiabing
Cc: Sven Peter, Alyssa Rosenzweig, Will Deacon, iommu, linux-kernel,
kael_w
On Wed, Oct 13, 2021 at 02:34:41AM -0400, Wan Jiabing wrote:
> Fix following coccicheck warning:
> drivers/iommu/apple-dart.c:704:20-27: WARNING opportunity for kmemdup
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/iommu/apple-dart.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-18 11:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-13 6:34 [PATCH] iommu/dart: use kmemdup instead of kzalloc and memcpy Wan Jiabing
2021-10-13 12:51 ` Alyssa Rosenzweig
2021-10-16 14:27 ` Sven Peter
2021-10-18 11:36 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox