From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86D4DC433EF for ; Wed, 13 Oct 2021 13:19:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BEB16109E for ; Wed, 13 Oct 2021 13:19:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233015AbhJMNVm (ORCPT ); Wed, 13 Oct 2021 09:21:42 -0400 Received: from rosenzweig.io ([138.197.143.207]:46934 "EHLO rosenzweig.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbhJMNVl (ORCPT ); Wed, 13 Oct 2021 09:21:41 -0400 Date: Wed, 13 Oct 2021 08:51:04 -0400 From: Alyssa Rosenzweig To: Wan Jiabing Cc: Sven Peter , Joerg Roedel , Will Deacon , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kael_w@yeah.net Subject: Re: [PATCH] iommu/dart: use kmemdup instead of kzalloc and memcpy Message-ID: References: <20211013063441.29888-1-wanjiabing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013063441.29888-1-wanjiabing@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Alyssa Rosenzweig On Wed, Oct 13, 2021 at 02:34:41AM -0400, Wan Jiabing wrote: > Fix following coccicheck warning: > drivers/iommu/apple-dart.c:704:20-27: WARNING opportunity for kmemdup > > Signed-off-by: Wan Jiabing > --- > drivers/iommu/apple-dart.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c > index 280ff8df728d..5eeb8d6b72e2 100644 > --- a/drivers/iommu/apple-dart.c > +++ b/drivers/iommu/apple-dart.c > @@ -701,13 +701,12 @@ static struct iommu_group *apple_dart_device_group(struct device *dev) > if (!group) > goto out; > > - group_master_cfg = kzalloc(sizeof(*group_master_cfg), GFP_KERNEL); > + group_master_cfg = kmemdup(cfg, sizeof(*group_master_cfg), GFP_KERNEL); > if (!group_master_cfg) { > iommu_group_put(group); > goto out; > } > > - memcpy(group_master_cfg, cfg, sizeof(*group_master_cfg)); > iommu_group_set_iommudata(group, group_master_cfg, > apple_dart_release_group); > > -- > 2.20.1 >