Re: [PATCH] tty: vt: replace snprintf in show functions with sysfs_emit

Greg Kroah-Hartman
2021-10-15T06:59:09Z

On Thu, Oct 14, 2021 at 11:51:36PM -0700, Qing Wang wrote:
> show() must not use snprintf() when formatting the value to be
> returned to user space.

Again, who is making this "must" requirement?

I, as the sysfs maintainer, am not saying that all existing show
functions MUST be converted, so I find it hard to believe that someone
else is...

>
> Fix the following coccicheck warning:
> drivers/tty/vt/vt.c:3902: WARNING: use scnprintf or sprintf.
> drivers/tty/vt/vt.c:3910: WARNING: use scnprintf or sprintf.

Someone needs to change this warning to show the correct thing here.

thanks,

greg k-h