From: Greg KH <gregkh@linuxfoundation.org>
To: Karolina Drobnik <karolinadrobnik@gmail.com>
Cc: outreachy-kernel@googlegroups.com, forest@alittletooquiet.net,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: vt6655: Rename byPreambleType field
Date: Fri, 15 Oct 2021 17:10:58 +0200 [thread overview]
Message-ID: <YWmaAqf8pusZGoBd@kroah.com> (raw)
In-Reply-To: <85dfe2c18e7ec4bd5ae67f7a81ab6197a82e0d86.camel@gmail.com>
On Fri, Oct 15, 2021 at 03:47:46PM +0100, Karolina Drobnik wrote:
> Hi Greg,
>
> On Fri, 2021-10-15 at 13:20 +0200, Greg KH wrote:
> > Do not do multiple different things in the same commit and especially
> > when you do not describe them in the changelog text.
>
> I wasn't aware that changing this preamble-related variable would be
> counted as a different thing. It makes sense, my bad.
>
> Would you like me to amend the message to say that I also changed
> `bb_get_frame_time` parameter or just drop this change completely?
I think I already answered this :)
prev parent reply other threads:[~2021-10-15 15:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 10:24 [PATCH v2] staging: vt6655: Rename byPreambleType field Karolina Drobnik
2021-10-15 11:20 ` Greg KH
2021-10-15 14:47 ` Karolina Drobnik
2021-10-15 15:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWmaAqf8pusZGoBd@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=forest@alittletooquiet.net \
--cc=karolinadrobnik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox