From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50222C433EF for ; Fri, 15 Oct 2021 15:11:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1775F6120A for ; Fri, 15 Oct 2021 15:11:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240867AbhJOPNJ (ORCPT ); Fri, 15 Oct 2021 11:13:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:58486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230430AbhJOPNH (ORCPT ); Fri, 15 Oct 2021 11:13:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D86516120A; Fri, 15 Oct 2021 15:11:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634310661; bh=3jYoDtUPdFBEUryZYNHsyBzPurObUQOppTxdHPamp+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SifqW+tmi83vgBOT/JG7an3SFgEf3U28avuIKl5gdn4/f/gwrbRGm3iB33QKZMh2h l/YFf6zbXWcmWmBz3JoYpQacXmxoGeDyp2fEr9h6qQ+iY5x6Y7R9Jxum9CMNImVdbE Z9xC2Ny5MQVrzuUhc/r9+Pk5Rp1Nl1N+SSUMezPA= Date: Fri, 15 Oct 2021 17:10:58 +0200 From: Greg KH To: Karolina Drobnik Cc: outreachy-kernel@googlegroups.com, forest@alittletooquiet.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: vt6655: Rename byPreambleType field Message-ID: References: <20211015102444.90753-1-karolinadrobnik@gmail.com> <85dfe2c18e7ec4bd5ae67f7a81ab6197a82e0d86.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85dfe2c18e7ec4bd5ae67f7a81ab6197a82e0d86.camel@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 15, 2021 at 03:47:46PM +0100, Karolina Drobnik wrote: > Hi Greg, > > On Fri, 2021-10-15 at 13:20 +0200, Greg KH wrote: > > Do not do multiple different things in the same commit and especially > > when you do not describe them in the changelog text. > > I wasn't aware that changing this preamble-related variable would be > counted as a different thing. It makes sense, my bad. > > Would you like me to amend the message to say that I also changed > `bb_get_frame_time` parameter or just drop this change completely? I think I already answered this :)