From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 534BAC433F5 for ; Mon, 18 Oct 2021 04:08:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 396206101B for ; Mon, 18 Oct 2021 04:08:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229759AbhJREKb (ORCPT ); Mon, 18 Oct 2021 00:10:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:40486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbhJREK1 (ORCPT ); Mon, 18 Oct 2021 00:10:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CDC7F61054; Mon, 18 Oct 2021 04:08:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634530096; bh=rSBoFOHyf4uqvRd9N6DL3e/GslL/J03tC/7EHWaZi3E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GNiq8RJFaXXbFz8y3UGY65yPyeavMA5V5D6q6NO0OlvtDz+pAZi0ZZx0hQR5v+NMG ODHw5JHoUqoL4Hu6vpC4ksx6ML1/YTwDT3/Znc6DktuI4f+h5/3bfclf21kgALKv0R lttRimYPr6ikF8CM0i1irSUDtZoxGQggzb3QwTPsOozMxlkkHi3NHItGsuiJEPgy8p tiPPTpDzwfz8rripUu2d4todpZIXSxkLpojZ6F5yxThIRv06O20CR1UqJ6BB/s2tck wnPNaJuKdnIqELqQUhMoap6oQc+mzOjItyINEVnJCMxszKhYuA8BTcUxbz1SJMM0ud DRos4LOInoqnA== Date: Mon, 18 Oct 2021 09:38:12 +0530 From: Vinod Koul To: Colin King Cc: dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: Remove redundant initialization of variable err Message-ID: References: <20211015123447.27560-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015123447.27560-1-colin.king@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-10-21, 13:34, Colin King wrote: > From: Colin Ian King > > The variable err is being initialized with a value that is never read, it > is being updated later on. The assignment is redundant and can be removed > and move the declaration into the local scope. Applied, thanks -- ~Vinod