public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf tools: Suppress 'rm dlfilter' build message
@ 2021-09-30  6:28 Adrian Hunter
  2021-09-30 10:40 ` kajoljain
  2021-10-20 14:38 ` Arnaldo Carvalho de Melo
  0 siblings, 2 replies; 3+ messages in thread
From: Adrian Hunter @ 2021-09-30  6:28 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo; +Cc: Jiri Olsa, linux-kernel

The following build message:

	rm dlfilters/dlfilter-test-api-v0.o

is unwanted.

The object fle is being treated as an intermediate file and being
automatically removed. Mark the object file as .SECONDARY to prevent
removal and hence the message.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 tools/perf/Makefile.perf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index e04313c4d840..ab8cb17d9ec5 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -787,6 +787,8 @@ $(OUTPUT)dlfilters/%.o: dlfilters/%.c include/perf/perf_dlfilter.h
 	$(Q)$(MKDIR) -p $(OUTPUT)dlfilters
 	$(QUIET_CC)$(CC) -c -Iinclude $(EXTRA_CFLAGS) -o $@ -fpic $<
 
+.SECONDARY: $(DLFILTERS:.so=.o)
+
 $(OUTPUT)dlfilters/%.so: $(OUTPUT)dlfilters/%.o
 	$(QUIET_LINK)$(CC) $(EXTRA_CFLAGS) -shared -o $@ $<
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] perf tools: Suppress 'rm dlfilter' build message
  2021-09-30  6:28 [PATCH] perf tools: Suppress 'rm dlfilter' build message Adrian Hunter
@ 2021-09-30 10:40 ` kajoljain
  2021-10-20 14:38 ` Arnaldo Carvalho de Melo
  1 sibling, 0 replies; 3+ messages in thread
From: kajoljain @ 2021-09-30 10:40 UTC (permalink / raw)
  To: Adrian Hunter, Arnaldo Carvalho de Melo; +Cc: Jiri Olsa, linux-kernel



On 9/30/21 11:58 AM, Adrian Hunter wrote:
> The following build message:
> 
> 	rm dlfilters/dlfilter-test-api-v0.o
> 
> is unwanted.
> 

Hi Adrian,

> The object fle is being treated as an intermediate file and being

Just minor nit, it should be `object file` not `object fle`

Thanks,
Kajol Jain

> automatically removed. Mark the object file as .SECONDARY to prevent
> removal and hence the message.
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>  tools/perf/Makefile.perf | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index e04313c4d840..ab8cb17d9ec5 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -787,6 +787,8 @@ $(OUTPUT)dlfilters/%.o: dlfilters/%.c include/perf/perf_dlfilter.h
>  	$(Q)$(MKDIR) -p $(OUTPUT)dlfilters
>  	$(QUIET_CC)$(CC) -c -Iinclude $(EXTRA_CFLAGS) -o $@ -fpic $<
>  
> +.SECONDARY: $(DLFILTERS:.so=.o)
> +
>  $(OUTPUT)dlfilters/%.so: $(OUTPUT)dlfilters/%.o
>  	$(QUIET_LINK)$(CC) $(EXTRA_CFLAGS) -shared -o $@ $<
>  
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] perf tools: Suppress 'rm dlfilter' build message
  2021-09-30  6:28 [PATCH] perf tools: Suppress 'rm dlfilter' build message Adrian Hunter
  2021-09-30 10:40 ` kajoljain
@ 2021-10-20 14:38 ` Arnaldo Carvalho de Melo
  1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-10-20 14:38 UTC (permalink / raw)
  To: Adrian Hunter; +Cc: Jiri Olsa, linux-kernel, kajoljain

Em Thu, Sep 30, 2021 at 09:28:49AM +0300, Adrian Hunter escreveu:
> The following build message:
> 
> 	rm dlfilters/dlfilter-test-api-v0.o
> 
> is unwanted.
> 
> The object fle is being treated as an intermediate file and being
> automatically removed. Mark the object file as .SECONDARY to prevent
> removal and hence the message.

Thanks, applied. Sorry for the delay, fell thru the cracks :-\ Also I
adjusted the fle typo reported by Kajol.

- Arnaldo

 
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>  tools/perf/Makefile.perf | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index e04313c4d840..ab8cb17d9ec5 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -787,6 +787,8 @@ $(OUTPUT)dlfilters/%.o: dlfilters/%.c include/perf/perf_dlfilter.h
>  	$(Q)$(MKDIR) -p $(OUTPUT)dlfilters
>  	$(QUIET_CC)$(CC) -c -Iinclude $(EXTRA_CFLAGS) -o $@ -fpic $<
>  
> +.SECONDARY: $(DLFILTERS:.so=.o)
> +
>  $(OUTPUT)dlfilters/%.so: $(OUTPUT)dlfilters/%.o
>  	$(QUIET_LINK)$(CC) $(EXTRA_CFLAGS) -shared -o $@ $<
>  
> -- 
> 2.25.1

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-20 14:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-30  6:28 [PATCH] perf tools: Suppress 'rm dlfilter' build message Adrian Hunter
2021-09-30 10:40 ` kajoljain
2021-10-20 14:38 ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox