From: Lee Jones <lee.jones@linaro.org>
To: Qing Wang <wangqing@vivo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: replace snprintf in show functions with sysfs_emit
Date: Thu, 21 Oct 2021 12:16:49 +0100 [thread overview]
Message-ID: <YXFMIUNWxUiYplsx@google.com> (raw)
In-Reply-To: <1634280592-4722-1-git-send-email-wangqing@vivo.com>
On Thu, 14 Oct 2021, Qing Wang wrote:
> show() must not use snprintf() when formatting the value to be
> returned to user space.
>
> Fix the following coccicheck warning:
> drivers/mfd/janz-cmodio.c:157: WARNING: use scnprintf or sprintf.
>
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>
> Signed-off-by: Qing Wang <wangqing@vivo.com>
> ---
> drivers/mfd/janz-cmodio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I've fixed the subject line for you and applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-10-21 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 6:49 [PATCH] mfd: replace snprintf in show functions with sysfs_emit Qing Wang
2021-10-21 11:16 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXFMIUNWxUiYplsx@google.com \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox