From: Andrew Lunn <andrew@lunn.ch>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Joakim Zhang <qiangqing.zhang@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: (EXT) Re: [PATCH] net: fec: defer probe if PHY on external MDIO bus is not available
Date: Thu, 21 Oct 2021 14:50:06 +0200 [thread overview]
Message-ID: <YXFh/nLTqvCsLAXj@lunn.ch> (raw)
In-Reply-To: <c286107376a99ca2201db058e1973e2b2264e9fb.camel@ew.tq-group.com>
> I would love to do this, but driver-api/driver-model/driver.rst
> contains the following warning:
>
> -EPROBE_DEFER must not be returned if probe() has already created
> child devices, even if those child devices are removed again
> in a cleanup path. If -EPROBE_DEFER is returned after a child
> device has been registered, it may result in an infinite loop of
> .probe() calls to the same driver.
>
> My understanding of this is that there is simply no way to return
> -EPROBE_DEFER after fec_enet_mii_init(pdev).
It might say that, but lots of network drivers actually do this. I've
not seen an endless loop.
Andrew
next prev parent reply other threads:[~2021-10-21 12:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 11:30 [PATCH] net: fec: defer probe if PHY on external MDIO bus is not available Matthias Schiffer
2021-10-18 10:20 ` Joakim Zhang
2021-10-18 10:32 ` Matthias Schiffer
2021-10-19 14:12 ` Andrew Lunn
2021-10-20 12:03 ` Matthias Schiffer
2021-10-20 18:50 ` Andrew Lunn
2021-10-21 7:08 ` (EXT) " Matthias Schiffer
2021-10-21 12:50 ` Andrew Lunn [this message]
2021-10-22 7:57 ` Matthias Schiffer
2021-10-22 12:56 ` Andrew Lunn
2021-10-26 11:54 ` Matthias Schiffer
2021-11-03 11:59 ` Matthias Schiffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXFh/nLTqvCsLAXj@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox