From: Vinod Koul <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
abhinavk@codeaurora.org, Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH v3 2/2] phy: qcom: Introduce new eDP PHY driver
Date: Fri, 22 Oct 2021 10:01:55 +0530 [thread overview]
Message-ID: <YXI+uwnMEJAnDllf@matsya> (raw)
In-Reply-To: <YXGvOHsJ33kJVvMk@ripper>
On 21-10-21, 11:19, Bjorn Andersson wrote:
> On Thu 21 Oct 10:40 PDT 2021, Vinod Koul wrote:
> > On 16-10-21, 16:21, Bjorn Andersson wrote:
> > > +static int qcom_edp_configure_ssc(const struct qcom_edp *edp)
> > > +{
> > > + const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts;
> > > + u32 step1;
> > > + u32 step2;
> > > +
> > > + switch (dp_opts->link_rate) {
> > > + case 1620:
> > > + case 2700:
> > > + case 8100:
> > > + step1 = 0x45;
> > > + step2 = 0x06;
> > > + break;
> >
> > line after each break please (here & few other places)
>
> You mean an empty line between the break and the next case? That doesn't
> seem standard?
Yes that is not really a standard, but does improve readability a lot esp
when blocks are large
> > > +static int qcom_edp_dp_pixel_clk_determine_rate(struct clk_hw *hw,
> > > + struct clk_rate_request *req)
> > > +{
> > > + switch (req->rate) {
> > > + case 1620000000UL / 2:
> > > + case 2700000000UL / 2:
> > > + /* 5.4 and 8.1 GHz are same link rate as 2.7GHz, i.e. div 4 and div 6 */
> >
> > above rates are 1.62 and 2.7, where is 5.4 and 8.1... what am i missing?
> >
>
> As the comments says 2.7, 5.4 and 8.1 all has req->rate of 1350000000,
> with different dividers. But we're not allowed to "document" that by
> listing 2.7/2, 5.4/4 and 8.1/6 in the switch statement.
ok
--
~Vinod
next prev parent reply other threads:[~2021-10-22 4:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 23:21 [PATCH v3 1/2] dt-bindings: phy: Introduce Qualcomm eDP/DP PHY binding Bjorn Andersson
2021-10-16 23:21 ` [PATCH v3 2/2] phy: qcom: Introduce new eDP PHY driver Bjorn Andersson
2021-10-21 17:40 ` Vinod Koul
2021-10-21 18:19 ` Bjorn Andersson
2021-10-22 4:31 ` Vinod Koul [this message]
2021-10-22 17:16 ` Bjorn Andersson
2021-10-25 7:10 ` Vinod Koul
2021-10-18 19:48 ` [PATCH v3 1/2] dt-bindings: phy: Introduce Qualcomm eDP/DP PHY binding Rob Herring
2021-10-21 14:51 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXI+uwnMEJAnDllf@matsya \
--to=vkoul@kernel.org \
--cc=abhinavk@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox