* Re: [PATCH] mailbox: remove the error message when gce clk is defer
[not found] <20211023164831.25690-1-jason-jh.lin@mediatek.com>
@ 2021-10-24 20:25 ` Russell King (Oracle)
0 siblings, 0 replies; only message in thread
From: Russell King (Oracle) @ 2021-10-24 20:25 UTC (permalink / raw)
To: jason-jh.lin
Cc: Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, Jassi Brar,
Yongqiang Niu, David Airlie, Daniel Vetter, dri-devel,
linux-mediatek, linux-arm-kernel, linux-kernel, hsinyi, fshao,
nancy.lin, singo.chang
On Sun, Oct 24, 2021 at 12:48:31AM +0800, jason-jh.lin wrote:
> Remove the error message when gce clk is defer.
>
> Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
> ---
> drivers/mailbox/mtk-cmdq-mailbox.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index fd5576a9f8b4..684b8aa1e445 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -577,7 +577,8 @@ static int cmdq_probe(struct platform_device *pdev)
> snprintf(clk_id, sizeof(clk_id), "%s%d", clk_name, alias_id);
> cmdq->clocks[alias_id].id = clk_id;
> cmdq->clocks[alias_id].clk = of_clk_get(node, 0);
> - if (IS_ERR(cmdq->clocks[alias_id].clk)) {
> + if (IS_ERR(cmdq->clocks[alias_id].clk) &&
> + PTR_ERR(cmdq->clocks[alias_id].clk) != -EPROBE_DEFER) {
> dev_err(dev, "failed to get gce clk: %d\n", alias_id);
> return PTR_ERR(cmdq->clocks[alias_id].clk);
> }
So when you get -EPROBE_DEFER, you omit the error message _and_ ignore
the -EPROBE_DEFER. Is that really what you want to do?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] only message in thread