From: Vinod Koul <vkoul@kernel.org>
To: Xin Xiong <xiongx18@fudan.edu.cn>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
yuanxzhang@fudan.edu.cn, Xiyu Yang <xiyuyang19@fudan.edu.cn>,
Xin Tan <tanxin.ctf@gmail.com>
Subject: Re: [PATCH] drivers/dma: fix reference count leaks in mmp_pdma_probe
Date: Mon, 25 Oct 2021 12:13:37 +0530 [thread overview]
Message-ID: <YXZSGe+BBbXEiXg3@matsya> (raw)
In-Reply-To: <20210911070533.3114-1-xiongx18@fudan.edu.cn>
On 11-09-21, 15:05, Xin Xiong wrote:
> The issue happens in an error handling path. If
> of_dma_controller_register() fails, the function simply prints error
> messages and returns error code, without decrementing the reference
> count of pdev->device incremented earlier by
> dma_async_device_register(), which may result in refcount leaks.
>
> Fix it by invoking dma_async_device_unregister() before returning the
> error code.
Pls use right subsystem tag, git log will tell u the same. I have fixe
dit up while applying
--
~Vinod
prev parent reply other threads:[~2021-10-25 6:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 7:05 [PATCH] drivers/dma: fix reference count leaks in mmp_pdma_probe Xin Xiong
2021-10-25 6:43 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXZSGe+BBbXEiXg3@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tanxin.ctf@gmail.com \
--cc=xiongx18@fudan.edu.cn \
--cc=xiyuyang19@fudan.edu.cn \
--cc=yuanxzhang@fudan.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox