From: Greg KH <gregkh@linuxfoundation.org>
To: Gaston Gonzalez <gascoar@gmail.com>
Cc: linux-staging@lists.linux.dev, nsaenz@kernel.org,
stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com,
ojaswin98@gmail.com, amarjargal16@gmail.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/8] staging: vchiq_core.h: use preferred kernel types
Date: Mon, 25 Oct 2021 09:11:20 +0200 [thread overview]
Message-ID: <YXZYmP0lCae+iDdE@kroah.com> (raw)
In-Reply-To: <20211024212524.370078-5-gascoar@gmail.com>
On Sun, Oct 24, 2021 at 06:25:20PM -0300, Gaston Gonzalez wrote:
> Change types from uint32_t and uint64_t to the preferred ones u32 and
> u64.
>
> Reported by checkpatch.pl, with the exception of the one in function
> vchiq_log_dump_mem().
>
> Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_core.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> index 383c3bcf787e..a107c72ce3a6 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> @@ -74,7 +74,7 @@
> ((fourcc) >> 8) & 0xff, \
> (fourcc) & 0xff
>
> -typedef uint32_t BITSET_T;
> +typedef u32 BITSET_T;
This is fine for now, but you should also work to get rid of this
unneeded typedef entirely.
thanks,
greg k-h
next prev parent reply other threads:[~2021-10-25 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 21:25 [PATCH v2 0/8] vchiq_core: various style cleanups Gaston Gonzalez
2021-10-24 21:25 ` [PATCH v2 1/8] staging: vchiq_core: cleanup blank lines Gaston Gonzalez
2021-10-24 21:25 ` [PATCH v2 2/8] staging: vchiq_core: cleanup code alignment issues Gaston Gonzalez
2021-10-24 21:25 ` [PATCH v2 3/8] staging: vchiq_core.h: fix CamelCase in function declaration Gaston Gonzalez
2021-10-24 21:25 ` [PATCH v2 4/8] staging: vchiq_core.h: use preferred kernel types Gaston Gonzalez
2021-10-25 7:11 ` Greg KH [this message]
2021-10-24 21:25 ` [PATCH v2 5/8] staging: vchiq: drop trailing semicolon in macro definition Gaston Gonzalez
2021-10-24 21:25 ` [PATCH v2 6/8] staging: vchiq_core: drop extern prefix in function declarations Gaston Gonzalez
2021-10-24 21:25 ` [PATCH v2 7/8] staging: vchiq_core: cleanup lines that end with '(' or '[' Gaston Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXZYmP0lCae+iDdE@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amarjargal16@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=gascoar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
--cc=ojaswin98@gmail.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox