From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B73E9C433EF for ; Tue, 26 Oct 2021 08:59:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BC51610F8 for ; Tue, 26 Oct 2021 08:59:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234557AbhJZJCI (ORCPT ); Tue, 26 Oct 2021 05:02:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbhJZJCH (ORCPT ); Tue, 26 Oct 2021 05:02:07 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FF69C061745 for ; Tue, 26 Oct 2021 01:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0hA9F2izcUGC40cVRcQ0tDFSmX7Q4rUQYCuTHCJ3bRY=; b=PdauVmbTEfXxx4kHsYgM2RQder N6z0NcQjMHMvVUd6LgQwW33d+H0wc7sTVyuH0BM1b10/8DWcU7SPElHAMSoxvu3J4uoFGQacbBZJZ 4oYjve/XFElbji/RX2Husw+iOvSt6/SdGDKR6/GGws/V65UrBxTJ/jO9JTMbOULpGwd+kV9fXIE6n IfyqMpeTjuvz7+DJzNlXVzNbv8rGNmO9J/+U8MqRveTpRoXAqxNv0kP2T2YlPmRFoSnm49CTMPT1x k8RPzU4HOuDhpLK1kgQyJyQudtzMtJY+JRTAXu3ChYoorzpjf3ErlqDsGI8LKgFmhaVlZloAsCNNJ flYKtvJw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55302) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mfIIy-00055M-UU; Tue, 26 Oct 2021 09:59:36 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mfIIw-0006cF-L9; Tue, 26 Oct 2021 09:59:34 +0100 Date: Tue, 26 Oct 2021 09:59:34 +0100 From: "Russell King (Oracle)" To: Linus Walleij Cc: quanyang.wang@windriver.com, Thomas Gleixner , Ard Biesheuvel , Linux ARM , linux-kernel Subject: Re: [PATCH] ARM: add BUILD_BUG_ON to check if fixmap range spans multiple pmds Message-ID: References: <20211020054942.1608637-1-quanyang.wang@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 24, 2021 at 11:44:31PM +0200, Linus Walleij wrote: > On Wed, Oct 20, 2021 at 7:50 AM wrote: > > > From: Quanyang Wang > > > > Not only the early fixmap range, but also the fixmap range should be > > checked if it spans multiple pmds. When enabling CONFIG_DEBUG_HIGHMEM, > > some systems which contain up to 16 CPUs will crash. > > > > Signed-off-by: Quanyang Wang > > Looks reasonable to me. > Reviewed-by: Linus Walleij > > Please submit this patch into Russell's patch tracker. ... and has totally broken what looks like _all_ ARM kernel builds. It can not have been tested. Maybe it's uncovered a previously unknown problem, but causing such a wide-range regression is disappointing. I'm going to revert this commit. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!