From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: kernel test robot <lkp@intel.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v2 1/2] serial: 8250_pci: Replace custom pci_match_id() implementation
Date: Tue, 26 Oct 2021 16:35:30 +0300 [thread overview]
Message-ID: <YXgEIhCGXjDUNDU0@smile.fi.intel.com> (raw)
In-Reply-To: <YXgB5vt8+r/Tdo07@smile.fi.intel.com>
On Tue, Oct 26, 2021 at 04:25:58PM +0300, Andy Shevchenko wrote:
> On Tue, Oct 26, 2021 at 08:45:48PM +0800, kernel test robot wrote:
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386
> > >> drivers/tty/serial/8250/8250_pci.c:1268:6: warning: variable 'amcc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
> > if (match)
> > ^~~~~
> > drivers/tty/serial/8250/8250_pci.c:1273:6: note: uninitialized use occurs here
> > if (amcc) {
> > ^~~~
> > drivers/tty/serial/8250/8250_pci.c:1268:2: note: remove the 'if' if its condition is always true
> > if (match)
> > ^~~~~~~~~~
> > drivers/tty/serial/8250/8250_pci.c:1265:11: note: initialize the variable 'amcc' to silence this warning
> > bool amcc;
> > ^
> > = 0
>
> Clang gives a right and wrong advice at the same time.
> Thank you for the uninitialized case, but variable is boolean, what's 0 here?
>
> I'll send a fix ASAP.
Hmm... GCC haven't showed anything here.
In any case, v3 has just been sent out.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-10-26 13:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 12:45 [PATCH v2 1/2] serial: 8250_pci: Replace custom pci_match_id() implementation Andy Shevchenko
2021-10-25 12:45 ` [PATCH v2 2/2] serial: 8250_pci: Remove empty stub pci_quatech_exit() Andy Shevchenko
2021-10-26 12:45 ` [PATCH v2 1/2] serial: 8250_pci: Replace custom pci_match_id() implementation kernel test robot
2021-10-26 13:25 ` Andy Shevchenko
2021-10-26 13:35 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXgEIhCGXjDUNDU0@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox