From: Greg KH <gregkh@linuxfoundation.org>
To: 常廉志 <changlianzhi@uniontech.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"dmitry.torokhov" <dmitry.torokhov@gmail.com>,
jirislaby <jirislaby@kernel.org>, 282827961 <282827961@qq.com>
Subject: Re: [PATCH v7] tty: Fix the keyboard led light display problem
Date: Tue, 26 Oct 2021 17:57:12 +0200 [thread overview]
Message-ID: <YXglWDgtWZdZhhUe@kroah.com> (raw)
In-Reply-To: <tencent_6F6E7845648EC1B76421AE7A@qq.com>
On Tue, Oct 26, 2021 at 11:41:17PM +0800, 常廉志 wrote:
> On Tue, Oct 26, 2021 at 05:23:35PM +0300, Andy Shevchenko wrote:
> > On Tue, Oct 26, 2021 at 10:40:32AM +0800, lianzhi chang wrote:
> > > Switching from the desktop environment to the tty environment,
> > > the state of the keyboard led lights and the state of the keyboard
> > > lock are inconsistent. This is because the attribute kb->kbdmode
> > > of the tty bound in the desktop environment (xorg) is set to
> >
> > Xorg
> >
> > I think I already pointed that out.
> >
> > > VC_OFF, which causes the ledstate and kb->ledflagstate
> > > values of the bound tty to always be 0, which causes the switch
> > > from the desktop When to the tty environment, the LED light
> > > status is inconsistent with the keyboard lock status.
> >
> > ...
> >
> > > +static void kbd_update_ledstate(struct input_dev *dev)
> > > +{
> > > + if (!!test_bit(LED_NUML, dev->led) !=
> > > + !!(ledstate & BIT(VC_NUMLOCK)))
> > > + ledstate ^= BIT(VC_NUMLOCK);
> > > + if (!!test_bit(LED_CAPSL, dev->led) !=
> > > + !!(ledstate & BIT(VC_CAPSLOCK)))
> > > + ledstate ^= BIT(VC_CAPSLOCK);
> > > + if (!!test_bit(LED_SCROLLL, dev->led) !=
> > > + !!(ledstate & BIT(VC_SCROLLOCK)))
> > > + ledstate ^= BIT(VC_SCROLLOCK);
> >
> > This looks ugly.
>
> I think it can be done like this:
> static void kbd_update_ledstate(struct input_dev *dev)
> {
> ledstate = (test_bit(LED_SCROLL,dev->led) ？1 ：0）
> | (test_bit(LED_NUML,dev->led) ？2 ：0）
> | (test_bit(LED_CAPSL,dev->led) ？3 ：0）
> }
Please write code for developers to read first, and compilers second.
That ? : stuff is a mess, do not do that.
thanks,
greg k-h
prev parent reply other threads:[~2021-10-26 15:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 2:40 [PATCH v7] tty: Fix the keyboard led light display problem lianzhi chang
2021-10-26 14:23 ` Andy Shevchenko
2021-10-26 14:53 ` Greg KH
2021-10-26 15:41 ` 常廉志
2021-10-26 15:57 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXglWDgtWZdZhhUe@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=282827961@qq.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=changlianzhi@uniontech.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox