From: Greg KH <gregkh@linuxfoundation.org>
To: vaatsalya shrivastava <shrivastavavaatsalya@gmail.com>
Cc: manohar.vanga@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: Cleaned a bit of code that was not required
Date: Thu, 28 Oct 2021 07:22:48 +0200 [thread overview]
Message-ID: <YXozqK1elRwpK0qf@kroah.com> (raw)
In-Reply-To: <20211027193235.5927-1-shrivastavavaatsalya@gmail.com>
On Wed, Oct 27, 2021 at 03:32:34PM -0400, vaatsalya shrivastava wrote:
> Warning found by checkpatch.pl script.
Please be specific as to what you did.
>
> Signed-off-by: vaatsalya shrivastava <shrivastavavaatsalya@gmail.com>
"V" and "S"?
> ---
> drivers/comedi/drivers/dt2815.c | 2 +-
> drivers/staging/vme/devices/vme_user.h | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/comedi/drivers/dt2815.c b/drivers/comedi/drivers/dt2815.c
> index 5906f32aa01f..2be240630bbd 100644
> --- a/drivers/comedi/drivers/dt2815.c
> +++ b/drivers/comedi/drivers/dt2815.c
> @@ -17,7 +17,7 @@
> * contrary, please update.
> *
> * Configuration options:
> - * [0] - I/O port base base address
> + * [0] - I/O port base address
The original is correct.
> * [1] - IRQ (unused)
> * [2] - Voltage unipolar/bipolar configuration
> * 0 == unipolar 5V (0V -- +5V)
> diff --git a/drivers/staging/vme/devices/vme_user.h b/drivers/staging/vme/devices/vme_user.h
> index 19ecb05781cc..3c1564fd9b20 100644
> --- a/drivers/staging/vme/devices/vme_user.h
> +++ b/drivers/staging/vme/devices/vme_user.h
This is not a comedi driver.
> @@ -14,11 +14,11 @@ struct vme_master {
> __u32 aspace; /* Address Space */
> __u32 cycle; /* Cycle properties */
> __u32 dwidth; /* Maximum Data Width */
> -#if 0
> +
You can not just remove these lines, please realize what you are doing.
thanks,
greg k-h
prev parent reply other threads:[~2021-10-28 5:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 19:32 [PATCH] staging: comedi: Cleaned a bit of code that was not required vaatsalya shrivastava
2021-10-28 5:22 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXozqK1elRwpK0qf@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@gmail.com \
--cc=shrivastavavaatsalya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox