[PATCH] staging: comedi: Cleaned a bit of code that was not required

[PATCH] staging: comedi: Cleaned a bit of code that was not required

[vaatsalya shrivastava]

Warning found by checkpatch.pl script.

Signed-off-by: vaatsalya shrivastava <shrivastavavaatsalya@gmail.com>
---
 drivers/comedi/drivers/dt2815.c        | 2 +-
 drivers/staging/vme/devices/vme_user.h | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/comedi/drivers/dt2815.c b/drivers/comedi/drivers/dt2815.c
index 5906f32aa01f..2be240630bbd 100644
--- a/drivers/comedi/drivers/dt2815.c
+++ b/drivers/comedi/drivers/dt2815.c
@@ -17,7 +17,7 @@
  * contrary, please update.
  *
  * Configuration options:
- * [0] - I/O port base base address
+ * [0] - I/O port base address
  * [1] - IRQ (unused)
  * [2] - Voltage unipolar/bipolar configuration
  *	0 == unipolar 5V  (0V -- +5V)
diff --git a/drivers/staging/vme/devices/vme_user.h b/drivers/staging/vme/devices/vme_user.h
index 19ecb05781cc..3c1564fd9b20 100644
--- a/drivers/staging/vme/devices/vme_user.h
+++ b/drivers/staging/vme/devices/vme_user.h
@@ -14,11 +14,11 @@ struct vme_master {
 	__u32 aspace;		/* Address Space */
 	__u32 cycle;		/* Cycle properties */
 	__u32 dwidth;		/* Maximum Data Width */
-#if 0
+
 	char prefetchenable;		/* Prefetch Read Enable State */
 	int prefetchsize;		/* Prefetch Read Size (Cache Lines) */
 	char wrpostenable;		/* Write Post State */
-#endif
+
 } __packed;
 
 /*
@@ -35,11 +35,11 @@ struct vme_slave {
 	__u64 size;		/* Window Size */
 	__u32 aspace;		/* Address Space */
 	__u32 cycle;		/* Cycle properties */
-#if 0
+
 	char wrpostenable;		/* Write Post State */
 	char rmwlock;			/* Lock PCI during RMW Cycles */
 	char data64bitcapable;		/* non-VMEbus capable of 64-bit Data */
-#endif
+
 } __packed;
 
 struct vme_irq_id {
-- 
2.30.2

Re: [PATCH] staging: comedi: Cleaned a bit of code that was not required

[Greg KH]

On Wed, Oct 27, 2021 at 03:32:34PM -0400, vaatsalya shrivastava wrote:
> Warning found by checkpatch.pl script.

Please be specific as to what you did.

> 
> Signed-off-by: vaatsalya shrivastava <shrivastavavaatsalya@gmail.com>

"V" and "S"?

> ---
>  drivers/comedi/drivers/dt2815.c        | 2 +-
>  drivers/staging/vme/devices/vme_user.h | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/comedi/drivers/dt2815.c b/drivers/comedi/drivers/dt2815.c
> index 5906f32aa01f..2be240630bbd 100644
> --- a/drivers/comedi/drivers/dt2815.c
> +++ b/drivers/comedi/drivers/dt2815.c
> @@ -17,7 +17,7 @@
>   * contrary, please update.
>   *
>   * Configuration options:
> - * [0] - I/O port base base address
> + * [0] - I/O port base address

The original is correct.

>   * [1] - IRQ (unused)
>   * [2] - Voltage unipolar/bipolar configuration
>   *	0 == unipolar 5V  (0V -- +5V)
> diff --git a/drivers/staging/vme/devices/vme_user.h b/drivers/staging/vme/devices/vme_user.h
> index 19ecb05781cc..3c1564fd9b20 100644
> --- a/drivers/staging/vme/devices/vme_user.h
> +++ b/drivers/staging/vme/devices/vme_user.h

This is not a comedi driver.

> @@ -14,11 +14,11 @@ struct vme_master {
>  	__u32 aspace;		/* Address Space */
>  	__u32 cycle;		/* Cycle properties */
>  	__u32 dwidth;		/* Maximum Data Width */
> -#if 0
> +

You can not just remove these lines, please realize what you are doing.

thanks,

greg k-h