From: Johan Hovold <johan@kernel.org>
To: Anssi Hannula <anssi.hannula@bitwise.fi>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: Fix extra "not" in TTY_DRIVER_REAL_RAW description
Date: Thu, 28 Oct 2021 10:45:05 +0200 [thread overview]
Message-ID: <YXpjEeeajd706Nak@hovoldconsulting.com> (raw)
In-Reply-To: <20211027102124.3049414-1-anssi.hannula@bitwise.fi>
On Wed, Oct 27, 2021 at 01:21:24PM +0300, Anssi Hannula wrote:
> TTY_DRIVER_REAL_RAW flag (which is always set for e.g. serial ports)
> documentation says that driver must always set special character
> handling flags in certain conditions.
>
> However, as the following sentence makes clear, what is actually
> intended is the opposite.
>
> Fix that by removing the unintended double negation.
>
> Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
> ---
Acked-by: Johan Hovold <johan@kernel.org>
> This one seems to have been there since 1994.
>
> include/linux/tty_driver.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/tty_driver.h b/include/linux/tty_driver.h
> index c20431d8def8..5bec04481c60 100644
> --- a/include/linux/tty_driver.h
> +++ b/include/linux/tty_driver.h
> @@ -360,7 +360,7 @@ static inline void tty_set_operations(struct tty_driver *driver,
> * Used for PTY's, in particular.
> *
> * TTY_DRIVER_REAL_RAW --- if set, indicates that the driver will
> - * guarantee never not to set any special character handling
> + * guarantee never to set any special character handling
> * flags if ((IGNBRK || (!BRKINT && !PARMRK)) && (IGNPAR ||
> * !INPCK)). That is, if there is no reason for the driver to
> * send notifications of parity and break characters up to the
prev parent reply other threads:[~2021-10-28 8:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 10:21 [PATCH] tty: Fix extra "not" in TTY_DRIVER_REAL_RAW description Anssi Hannula
2021-10-28 8:45 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXpjEeeajd706Nak@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=anssi.hannula@bitwise.fi \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox