From: Greg KH <gregkh@linuxfoundation.org>
To: Hans-Gert Dahmen <hans-gert.dahmen@immu.ne>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Richard Hughes <hughsient@gmail.com>,
Mauro Lima <mauro.lima@eclypsium.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Philipp Deppenwiese <philipp.deppenwiese@immu.ne>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH] firmware: export x86_64 platform flash bios region via sysfs
Date: Thu, 11 Nov 2021 12:43:15 +0100 [thread overview]
Message-ID: <YY0B0yBshwK9azJO@kroah.com> (raw)
In-Reply-To: <CAHifhD4cmsTFc02xNMWnMA74qMQcWMjNoseV3uRjwpY2N9xJ1A@mail.gmail.com>
On Thu, Nov 11, 2021 at 11:55:25AM +0100, Hans-Gert Dahmen wrote:
> > My concern of
> > removing the DANGEROUS tag is that we end up bricking yet another Lenovo
> > laptop by accident. Avoiding that would give me more peace of mind :)
>
> Yes of course, I think to not endanger users with malfunctions caused
> by code we produce is of our mutual interest here and we should make
> sure to be absolutely serious about it.
This is why I was saying that the driver HAS to specify the hardware
that it is allowed to bind to, and only bind to that hardware. Your
driver today does not take that into account at all, which is my primary
objection to the code as-is.
thanks,
greg k-h
next prev parent reply other threads:[~2021-11-11 11:43 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 0:01 [PATCH] firmware: export x86_64 platform flash bios region via sysfs Hans-Gert Dahmen
2021-11-09 6:16 ` Greg KH
2021-11-09 8:52 ` Hans-Gert Dahmen
2021-11-09 8:56 ` Hans-Gert Dahmen
2021-11-09 10:28 ` Greg KH
2021-11-09 12:32 ` Hans-Gert Dahmen
2021-11-09 12:42 ` Greg KH
2021-11-09 14:09 ` Mauro Lima
2021-11-09 14:11 ` Mauro Lima
2021-11-09 14:10 ` Hans-Gert Dahmen
[not found] ` <CAHp75VfbYsyC=7Ncnex1f_jiwrZhExDF7iy4oSGZgS1cHmsN0Q@mail.gmail.com>
2021-11-10 8:37 ` Hans-Gert Dahmen
2021-11-10 9:04 ` Andy Shevchenko
2021-11-10 9:17 ` Hans-Gert Dahmen
2021-11-10 9:25 ` Andy Shevchenko
2021-11-10 10:00 ` Hans-Gert Dahmen
2021-11-10 13:13 ` Mauro Lima
2021-11-10 16:31 ` Andy Shevchenko
2021-11-10 17:37 ` Mauro Lima
2021-11-11 6:42 ` Mika Westerberg
2021-11-11 8:59 ` Hans-Gert Dahmen
2021-11-11 10:32 ` Mika Westerberg
2021-11-11 10:55 ` Hans-Gert Dahmen
2021-11-11 11:43 ` Greg KH [this message]
2021-11-11 11:46 ` Richard Hughes
2021-11-11 12:46 ` Andy Shevchenko
2021-11-11 12:56 ` Hans-Gert Dahmen
2021-11-11 13:54 ` Andy Shevchenko
2021-11-11 14:33 ` Hans-Gert Dahmen
2021-11-11 15:30 ` Andy Shevchenko
2021-11-11 15:43 ` Ard Biesheuvel
2021-11-11 15:49 ` Andy Shevchenko
2021-11-11 16:05 ` Hans-Gert Dahmen
2021-11-11 21:07 ` Richard Hughes
2021-11-12 6:52 ` Greg KH
2021-11-12 10:09 ` Richard Hughes
2021-11-12 10:43 ` Greg KH
2021-11-12 12:25 ` Hans-Gert Dahmen
2021-11-11 16:07 ` Hans-Gert Dahmen
2021-11-11 16:44 ` Andy Shevchenko
2021-11-11 16:55 ` Hans-Gert Dahmen
2021-11-11 17:48 ` Andy Shevchenko
2021-11-11 18:14 ` Hans-Gert Dahmen
2021-11-11 19:14 ` Ard Biesheuvel
2021-11-11 20:50 ` Hans-Gert Dahmen
2021-11-11 13:00 ` Mika Westerberg
2021-11-11 13:22 ` Richard Hughes
2021-11-11 13:34 ` Mika Westerberg
2021-11-11 13:36 ` Hans-Gert Dahmen
2021-11-11 14:42 ` Mauro Lima
2021-11-11 15:06 ` Mika Westerberg
2021-11-11 15:16 ` Hans-Gert Dahmen
2021-11-12 6:59 ` Mika Westerberg
2021-11-11 15:31 ` Mauro Lima
2021-11-11 11:50 ` Mauro Lima
2021-11-10 17:41 ` Hans-Gert Dahmen
[not found] ` <E1CBFD23-AC3B-43BF-BF0A-158844486BA9@getmailspring.com>
2021-11-09 10:24 ` Greg KH
2021-11-09 10:30 ` Philipp Deppenwiese
2021-11-09 11:25 ` Greg KH
2021-11-09 13:55 ` Mauro Lima
2021-11-09 16:12 ` Greg KH
2021-11-09 17:23 ` Mauro Lima
-- strict thread matches above, loose matches on Subject: below --
2021-06-22 14:23 Hans-Gert Dahmen
2021-06-22 20:02 ` Greg KH
2021-06-25 13:54 ` Hans-Gert Dahmen
2021-06-22 22:18 ` David Laight
2021-06-23 12:17 ` Hans-Gert Dahmen
2021-06-23 12:40 ` gregkh
2021-06-24 11:20 ` Hans-Gert Dahmen
2021-06-24 11:42 ` gregkh
2021-06-23 13:22 ` David Laight
2021-06-18 16:47 Hans-Gert Dahmen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YY0B0yBshwK9azJO@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=hans-gert.dahmen@immu.ne \
--cc=hughsient@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mauro.lima@eclypsium.com \
--cc=mika.westerberg@linux.intel.com \
--cc=philipp.deppenwiese@immu.ne \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox