From: Mark Brown <broonie@kernel.org>
To: nandhini.srikandan@intel.com
Cc: fancer.lancer@gmail.com, robh+dt@kernel.org,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, mgross@linux.intel.com,
kris.pan@intel.com, kenchappa.demakkanavar@intel.com,
furong.zhou@intel.com, mallikarjunappa.sangannavar@intel.com,
mahesh.r.vaidya@intel.com, rashmi.a@intel.com
Subject: Re: [PATCH v3 3/5] spi: dw: Add support for master mode selection for DWC SSI controller
Date: Thu, 11 Nov 2021 14:16:05 +0000 [thread overview]
Message-ID: <YY0lpZkIsJih+g2o@sirena.org.uk> (raw)
In-Reply-To: <20211111065201.10249-4-nandhini.srikandan@intel.com>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Thu, Nov 11, 2021 at 02:51:59PM +0800, nandhini.srikandan@intel.com wrote:
> Add support to select the controller mode as master mode by setting
> Bit 31 of CTRLR0 register. This feature is supported for controller
> versions above v1.02.
Clearly older versions of the controller can also run in this mode...
> - if (dws->caps & DW_SPI_CAP_KEEMBAY_MST)
> - cr0 |= DWC_SSI_CTRLR0_KEEMBAY_MST;
> + /* CTRLR0[31] MST */
> + cr0 |= DWC_SSI_CTRLR0_MST;
This makes the configuration unconditional, it's not gated by controller
version checks or any kind of quirk any more meaning that if anything
interprets that bit differently things might break. If this is really
required to put the controller in master mode it seems that either the
1.02 version is not widespread or this is generally the hardware
default.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-11-11 14:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 6:51 [PATCH v3 0/5] Add support for Intel Thunder Bay SPI controller nandhini.srikandan
2021-11-11 6:51 ` [PATCH v3 1/5] dt-bindings: spi: Add SSTE support for DWC SSI controller nandhini.srikandan
2021-11-11 13:53 ` Mark Brown
2021-11-11 14:31 ` Serge Semin
2021-11-11 15:01 ` Mark Brown
2021-11-11 15:06 ` Serge Semin
2021-11-17 12:05 ` Srikandan, Nandhini
2021-11-11 6:51 ` [PATCH v3 2/5] spi: dw: " nandhini.srikandan
2021-11-11 13:56 ` Mark Brown
2021-11-11 14:16 ` Serge Semin
2021-11-11 14:42 ` Serge Semin
2021-11-11 6:51 ` [PATCH v3 3/5] spi: dw: Add support for master mode selection " nandhini.srikandan
2021-11-11 14:16 ` Mark Brown [this message]
2021-11-11 14:52 ` Serge Semin
2021-11-11 15:14 ` Mark Brown
2021-11-11 16:06 ` Serge Semin
2021-11-11 16:25 ` Mark Brown
2021-11-16 19:15 ` Serge Semin
2021-11-17 11:59 ` Srikandan, Nandhini
2021-12-08 11:03 ` Srikandan, Nandhini
2021-12-09 8:40 ` Serge Semin
2021-11-11 6:52 ` [PATCH v3 4/5] dt-bindings: spi: Add bindings for Intel Thunder Bay SoC nandhini.srikandan
2021-11-19 16:55 ` Rob Herring
2021-11-11 6:52 ` [PATCH v3 5/5] spi: dw: Add support for Intel Thunder Bay SPI controller nandhini.srikandan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YY0lpZkIsJih+g2o@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=furong.zhou@intel.com \
--cc=kenchappa.demakkanavar@intel.com \
--cc=kris.pan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mahesh.r.vaidya@intel.com \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mgross@linux.intel.com \
--cc=nandhini.srikandan@intel.com \
--cc=rashmi.a@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox