From: Borislav Petkov <bp@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL (not really)] x86/core for v5.16
Date: Tue, 2 Nov 2021 06:22:55 +0100 [thread overview]
Message-ID: <YYDLL7aHi3c8jpmC@zn.tnic> (raw)
In-Reply-To: <CAHk-=wiNyR-cAxicOD6nkRQNw-q+uzFvB3hpA-s=7asEKom=og@mail.gmail.com>
On Mon, Nov 01, 2021 at 02:16:24PM -0700, Linus Torvalds wrote:
> So other developers do this kind of thing fairly regularly, because
> they have some "core branch" that does the basic core development
> (say, a driver subsystem), and then they have other branches (eg the
> lowlevel drivers themselves etc) that depended on the core work but
> are sent as individual pull requests to keep the conceptual separation
> alive, and make it easier to review.
Right, exactly.
> The way to do it tends to be:
>
> (a) make it clear that some pull request depends on a previous one,
> so that I'm aware of it, and don't do them out of order and get
> confused
Ok.
> (b) when you have a series of pull requests that aren't independent,
> create the series of pulls yourself in a temporary tree, and generate
> the pull request from that series, with the previous merge always as
> the "base".
Ah ok, that sounds good.
> The reason for (a) is obvious, and the reason for (b) is that then
> each pull request automatically gets the right shortlog and diffstat.
>
> Of course, if this is the only time you expect to haev this kind of
> dependency, you don't need to have much of a process in place, and a
> hacky manual one-time thing like the above works fine too.
Yeah, it does happen but not too often. With tip, the usual situation
is one branch does change/add something which is needed elsewhere and a
merge is needed. Basically the case you described above.
> And in general, the more independent the pull request can be, the
> better. But having two or more branches that have some serial
> dependency certainly isn't unheard of or wrong either. It happens.
Yeah.
Ok, thanks for explaining.
/me writes this down for the future.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Ivo Totev, HRB 36809, AG Nürnberg
next prev parent reply other threads:[~2021-11-02 5:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 10:25 [GIT PULL (not really)] x86/core for v5.16 Borislav Petkov
2021-11-01 21:16 ` Linus Torvalds
2021-11-02 5:22 ` Borislav Petkov [this message]
2021-11-02 5:48 ` [GIT PULL] " Borislav Petkov
2021-11-02 15:07 ` [GIT PULL (not really)] " pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYDLL7aHi3c8jpmC@zn.tnic \
--to=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox