Re: [PATCH] net: ethernet: cortina: permit to set mac address in DT

Andrew Lunn
2021-10-27T00:08:18Z

On Tue, Oct 26, 2021 at 07:17:03PM +0000, Corentin Labbe wrote:
> Add ability of setting mac address in DT for cortina ethernet driver.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> drivers/net/ethernet/cortina/gemini.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
> index 941f175fb911..f6aa2387a1af 100644
> --- a/drivers/net/ethernet/cortina/gemini.c
> +++ b/drivers/net/ethernet/cortina/gemini.c
> @@ -2356,12 +2356,14 @@ static void gemini_port_save_mac_addr(struct gemini_ethernet_port *port)
> static int gemini_ethernet_port_probe(struct platform_device *pdev)
> {
> char *port_names[2] = { "ethernet0", "ethernet1" };
> + struct device_node *np = pdev->dev.of_node;
> struct gemini_ethernet_port *port;
> struct device *dev = &pdev->dev;
> struct gemini_ethernet *geth;
> struct net_device *netdev;
> struct device *parent;
> unsigned int id;
> + u8 mac[ETH_ALEN];

Off by one in terms of reverse Christmas tree.

Andrew