From: Johan Hovold <johan@kernel.org>
To: cgel.zte@gmail.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Jing Yao <yao.jing2@zte.com.cn>, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] drivers: most: replace snprintf in show functions with sysfs_emit
Date: Wed, 3 Nov 2021 09:27:42 +0100 [thread overview]
Message-ID: <YYJH/lYLQJdM2H1p@hovoldconsulting.com> (raw)
In-Reply-To: <20211103082313.27570-1-yao.jing2@zte.com.cn>
On Wed, Nov 03, 2021 at 08:23:13AM +0000, cgel.zte@gmail.com wrote:
> From: Jing Yao <yao.jing2@zte.com.cn>
>
> coccicheck complains about the use of snprintf() in sysfs show
> funcitons:
> WARNING use scnprintf or sprintf
>
> Use sysfs_emit instead of scnprintf, snprintf or sprintf makes more
> sense.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jing Yao <yao.jing2@zte.com.cn>
Again, no need to include "drivers: " in the Subject, even if in this
case the single commit adding this file also got this wrong.
Johan
next prev parent reply other threads:[~2021-11-03 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 8:23 [PATCH] drivers: most: replace snprintf in show functions with sysfs_emit cgel.zte
2021-11-03 8:27 ` Johan Hovold [this message]
2021-11-04 11:45 ` [PATCH v2] " cgel.zte
2021-11-08 9:50 ` Johan Hovold
2021-11-10 2:53 ` [PATCH v3] most: usb: " cgel.zte
2021-11-03 8:28 ` [PATCH] drivers: most: " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYJH/lYLQJdM2H1p@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=cgel.zte@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yao.jing2@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox