Re: [PATCH] regulator: qcom_spmi: do no register unused regulators

Mark Brown
2021-11-04T13:44:43Z

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

On Thu, Nov 04, 2021 at 09:23:03AM +0100, Stephan Gerhold wrote:
> On Thu, Nov 04, 2021 at 03:43:51AM +0300, Dmitry Baryshkov wrote:

> > Typically SPMI interface to PMIC regulators on Qualcomm platforms is
> > used to supplement RPM interface in cases where direct control is
> > required (e.g. for the APCC or GFX regulators). Registering all possible
> > regulators is thus not required and may be potentially harmfull if
> > somebody tries to setup those directly. Thus register only regulators
> > that are really used in the device tree and ignore all unused
> > regulators.

> Shouldn't the missing regulator constraints already take care of that?
> If you don't setup any voltage etc in the device tree it should
> effectively make the regulator read-only.

Right, we won't touch the hardware configuration unless there are
constraints explicitly permitting it. Drivers should always register
any regulators that are physically present unconditionally, the core
will only make changes if the system integration permits it. Open
coding this in drivers just causes code duplication and creates issues
if there's changes in the generic bindings.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]