[PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency

[PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency

[Tyler Hicks]

Select CONFIG_MFD_CORE from CONFIG_MFD_SIMPLE_MFD_I2C, now that
simple-mfd-i2c.c calls devm_mfd_add_devices(), to fix the following
linker error:

 ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
 simple-mfd-i2c.c:(.text+0x62): undefined reference to `devm_mfd_add_devices'
 make: *** [Makefile:1187: vmlinux] Error 1

Fixes: c753ea31781a ("mfd: simple-mfd-i2c: Add support for registering devices via MFD cells")
Cc: stable@vger.kernel.org # 5.15.x
Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
---
 drivers/mfd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index ca0edab91aeb..d2f345245538 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1194,6 +1194,7 @@ config MFD_SI476X_CORE
 config MFD_SIMPLE_MFD_I2C
 	tristate
 	depends on I2C
+	select MFD_CORE
 	select REGMAP_I2C
 	help
 	  This driver creates a single register map with the intention for it
-- 
2.25.1

Re: [PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency

[Alistair]

On Thu, Nov 4, 2021, at 5:04 AM, Tyler Hicks wrote:
> Select CONFIG_MFD_CORE from CONFIG_MFD_SIMPLE_MFD_I2C, now that
> simple-mfd-i2c.c calls devm_mfd_add_devices(), to fix the following
> linker error:
> 
> ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
> simple-mfd-i2c.c:(.text+0x62): undefined reference to `devm_mfd_add_devices'
> make: *** [Makefile:1187: vmlinux] Error 1
> 
> Fixes: c753ea31781a ("mfd: simple-mfd-i2c: Add support for registering devices via MFD cells")
> Cc: stable@vger.kernel.org # 5.15.x
> Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>

Reviewed-by: Alistair Francis <alistair@alistair23.me>

Alistair

> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index ca0edab91aeb..d2f345245538 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1194,6 +1194,7 @@ config MFD_SI476X_CORE
> config MFD_SIMPLE_MFD_I2C
> tristate
> depends on I2C
> + select MFD_CORE
> select REGMAP_I2C
> help
>   This driver creates a single register map with the intention for it
> -- 
> 2.25.1
> 
> 

Re: [PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency

[Lee Jones]

On Wed, 03 Nov 2021, Tyler Hicks wrote:

> Select CONFIG_MFD_CORE from CONFIG_MFD_SIMPLE_MFD_I2C, now that
> simple-mfd-i2c.c calls devm_mfd_add_devices(), to fix the following
> linker error:
> 
>  ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
>  simple-mfd-i2c.c:(.text+0x62): undefined reference to `devm_mfd_add_devices'
>  make: *** [Makefile:1187: vmlinux] Error 1
> 
> Fixes: c753ea31781a ("mfd: simple-mfd-i2c: Add support for registering devices via MFD cells")
> Cc: stable@vger.kernel.org # 5.15.x
> Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
> ---
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Looks like the same change that has already been applied.

Could you rebase on top of the MFD tree please?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency

[Tyler Hicks]

On 2021-11-04 08:24:28, Lee Jones wrote:
> On Wed, 03 Nov 2021, Tyler Hicks wrote:
> 
> > Select CONFIG_MFD_CORE from CONFIG_MFD_SIMPLE_MFD_I2C, now that
> > simple-mfd-i2c.c calls devm_mfd_add_devices(), to fix the following
> > linker error:
> > 
> >  ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
> >  simple-mfd-i2c.c:(.text+0x62): undefined reference to `devm_mfd_add_devices'
> >  make: *** [Makefile:1187: vmlinux] Error 1
> > 
> > Fixes: c753ea31781a ("mfd: simple-mfd-i2c: Add support for registering devices via MFD cells")
> > Cc: stable@vger.kernel.org # 5.15.x
> > Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
> > ---
> >  drivers/mfd/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Looks like the same change that has already been applied.
> 
> Could you rebase on top of the MFD tree please?

Ah, that commit wasn't in for-mfd-next when I wrote up this patch
yesterday.

I think that the Fixes line in that patch is wrong as I didn't see this
issue in 5.10 and reverting c753ea31781a fixes the build failure.

Tyler

> 
> -- 
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
> 

Re: [PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency

[Robert Marko]

On Thu, Nov 4, 2021 at 2:53 PM Tyler Hicks <tyhicks@linux.microsoft.com> wrote:
>
> On 2021-11-04 08:24:28, Lee Jones wrote:
> > On Wed, 03 Nov 2021, Tyler Hicks wrote:
> >
> > > Select CONFIG_MFD_CORE from CONFIG_MFD_SIMPLE_MFD_I2C, now that
> > > simple-mfd-i2c.c calls devm_mfd_add_devices(), to fix the following
> > > linker error:
> > >
> > >  ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
> > >  simple-mfd-i2c.c:(.text+0x62): undefined reference to `devm_mfd_add_devices'
> > >  make: *** [Makefile:1187: vmlinux] Error 1
> > >
> > > Fixes: c753ea31781a ("mfd: simple-mfd-i2c: Add support for registering devices via MFD cells")
> > > Cc: stable@vger.kernel.org # 5.15.x
> > > Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
> > > ---
> > >  drivers/mfd/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> >
> > Looks like the same change that has already been applied.
> >
> > Could you rebase on top of the MFD tree please?
>
> Ah, that commit wasn't in for-mfd-next when I wrote up this patch
> yesterday.
>
> I think that the Fixes line in that patch is wrong as I didn't see this
> issue in 5.10 and reverting c753ea31781a fixes the build failure.

Hi Tyler, I would agree with you on the fixes tag.
I messed that one up, c753ea31781a is the correct one.

Regards,
Robert
>
> Tyler
>
> >
> > --
> > Lee Jones [李琼斯]
> > Senior Technical Lead - Developer Services
> > Linaro.org │ Open source software for Arm SoCs
> > Follow Linaro: Facebook | Twitter | Blog
> >



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr

Re: [PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency

[Lee Jones]

On Thu, 04 Nov 2021, Robert Marko wrote:

> On Thu, Nov 4, 2021 at 2:53 PM Tyler Hicks <tyhicks@linux.microsoft.com> wrote:
> >
> > On 2021-11-04 08:24:28, Lee Jones wrote:
> > > On Wed, 03 Nov 2021, Tyler Hicks wrote:
> > >
> > > > Select CONFIG_MFD_CORE from CONFIG_MFD_SIMPLE_MFD_I2C, now that
> > > > simple-mfd-i2c.c calls devm_mfd_add_devices(), to fix the following
> > > > linker error:
> > > >
> > > >  ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
> > > >  simple-mfd-i2c.c:(.text+0x62): undefined reference to `devm_mfd_add_devices'
> > > >  make: *** [Makefile:1187: vmlinux] Error 1
> > > >
> > > > Fixes: c753ea31781a ("mfd: simple-mfd-i2c: Add support for registering devices via MFD cells")
> > > > Cc: stable@vger.kernel.org # 5.15.x
> > > > Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
> > > > ---
> > > >  drivers/mfd/Kconfig | 1 +
> > > >  1 file changed, 1 insertion(+)
> > >
> > > Looks like the same change that has already been applied.
> > >
> > > Could you rebase on top of the MFD tree please?
> >
> > Ah, that commit wasn't in for-mfd-next when I wrote up this patch
> > yesterday.
> >
> > I think that the Fixes line in that patch is wrong as I didn't see this
> > issue in 5.10 and reverting c753ea31781a fixes the build failure.
> 
> Hi Tyler, I would agree with you on the fixes tag.
> I messed that one up, c753ea31781a is the correct one.

All good.  I fixed it for you.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency

[Robert Marko]

On Thu, Nov 4, 2021 at 3:09 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Thu, 04 Nov 2021, Robert Marko wrote:
>
> > On Thu, Nov 4, 2021 at 2:53 PM Tyler Hicks <tyhicks@linux.microsoft.com> wrote:
> > >
> > > On 2021-11-04 08:24:28, Lee Jones wrote:
> > > > On Wed, 03 Nov 2021, Tyler Hicks wrote:
> > > >
> > > > > Select CONFIG_MFD_CORE from CONFIG_MFD_SIMPLE_MFD_I2C, now that
> > > > > simple-mfd-i2c.c calls devm_mfd_add_devices(), to fix the following
> > > > > linker error:
> > > > >
> > > > >  ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
> > > > >  simple-mfd-i2c.c:(.text+0x62): undefined reference to `devm_mfd_add_devices'
> > > > >  make: *** [Makefile:1187: vmlinux] Error 1
> > > > >
> > > > > Fixes: c753ea31781a ("mfd: simple-mfd-i2c: Add support for registering devices via MFD cells")
> > > > > Cc: stable@vger.kernel.org # 5.15.x
> > > > > Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
> > > > > ---
> > > > >  drivers/mfd/Kconfig | 1 +
> > > > >  1 file changed, 1 insertion(+)
> > > >
> > > > Looks like the same change that has already been applied.
> > > >
> > > > Could you rebase on top of the MFD tree please?
> > >
> > > Ah, that commit wasn't in for-mfd-next when I wrote up this patch
> > > yesterday.
> > >
> > > I think that the Fixes line in that patch is wrong as I didn't see this
> > > issue in 5.10 and reverting c753ea31781a fixes the build failure.
> >
> > Hi Tyler, I would agree with you on the fixes tag.
> > I messed that one up, c753ea31781a is the correct one.
>
> All good.  I fixed it for you.

Thanks, sorry for the mess up.

Regards,
Robert
>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr

Re: [PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency

[Tyler Hicks]

On 2021-11-04 15:00:40, Robert Marko wrote:
> On Thu, Nov 4, 2021 at 2:53 PM Tyler Hicks <tyhicks@linux.microsoft.com> wrote:
> >
> > On 2021-11-04 08:24:28, Lee Jones wrote:
> > > On Wed, 03 Nov 2021, Tyler Hicks wrote:
> > >
> > > > Select CONFIG_MFD_CORE from CONFIG_MFD_SIMPLE_MFD_I2C, now that
> > > > simple-mfd-i2c.c calls devm_mfd_add_devices(), to fix the following
> > > > linker error:
> > > >
> > > >  ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
> > > >  simple-mfd-i2c.c:(.text+0x62): undefined reference to `devm_mfd_add_devices'
> > > >  make: *** [Makefile:1187: vmlinux] Error 1
> > > >
> > > > Fixes: c753ea31781a ("mfd: simple-mfd-i2c: Add support for registering devices via MFD cells")
> > > > Cc: stable@vger.kernel.org # 5.15.x
> > > > Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
> > > > ---
> > > >  drivers/mfd/Kconfig | 1 +
> > > >  1 file changed, 1 insertion(+)
> > >
> > > Looks like the same change that has already been applied.
> > >
> > > Could you rebase on top of the MFD tree please?
> >
> > Ah, that commit wasn't in for-mfd-next when I wrote up this patch
> > yesterday.
> >
> > I think that the Fixes line in that patch is wrong as I didn't see this
> > issue in 5.10 and reverting c753ea31781a fixes the build failure.
> 
> Hi Tyler, I would agree with you on the fixes tag.
> I messed that one up, c753ea31781a is the correct one.

It is probably better to overshoot than undershoot with Fixes tags. :)

Lee, I don't know if you rebase that branch (I doubt it) but if you do
to fix up the Fixes tag, please also add an explicit Cc: stable tag
since this affects the new LTS release.

Tyler

> 
> Regards,
> Robert
> >
> > Tyler
> >
> > >
> > > --
> > > Lee Jones [李琼斯]
> > > Senior Technical Lead - Developer Services
> > > Linaro.org │ Open source software for Arm SoCs
> > > Follow Linaro: Facebook | Twitter | Blog
> > >
> 
> 
> 
> -- 
> Robert Marko
> Staff Embedded Linux Engineer
> Sartura Ltd.
> Lendavska ulica 16a
> 10000 Zagreb, Croatia
> Email: robert.marko@sartura.hr
> Web: www.sartura.hr
>