From: Matthew Wilcox <willy@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>
Cc: linux-arch@vger.kernel.org, Ira Weiny <ira.weiny@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: flush_dcache_page vs kunmap_local
Date: Thu, 4 Nov 2021 15:00:36 +0000 [thread overview]
Message-ID: <YYP1lAq46NWzhOf0@casper.infradead.org> (raw)
In https://lore.kernel.org/lkml/CAHk-=wijdojzo56FzYqE5TOYw2Vws7ik3LEMGj9SPQaJJ+Z73Q@mail.gmail.com/
Linus offers the opinion that kunmap calls should imply a
flush_dcache_page(). Christoph added calls to flush_dcache_page()
in commit 8dad53a11f8d. Was this "voodoo programming", or was there
a real problem being addressed?
next reply other threads:[~2021-11-04 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 15:00 Matthew Wilcox [this message]
2021-11-04 15:30 ` flush_dcache_page vs kunmap_local Linus Torvalds
2021-11-04 16:54 ` Catalin Marinas
2021-11-04 17:08 ` Linus Torvalds
2021-11-04 18:04 ` Catalin Marinas
2021-11-04 18:20 ` Russell King (Oracle)
2021-11-04 18:23 ` Linus Torvalds
2021-11-05 19:40 ` Catalin Marinas
2021-11-04 18:38 ` Matthew Wilcox
2021-11-04 21:02 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYP1lAq46NWzhOf0@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox