From: Johannes Weiner <hannes@cmpxchg.org>
To: Liu Xinpeng <liuxp11@chinatelecom.cn>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
juri.lelli@redhat.com, zhouchengming@bytedance.com,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/2] psi: Remove repeated verbose comment
Date: Thu, 4 Nov 2021 12:49:51 -0400 [thread overview]
Message-ID: <YYQPL4exZUP2eruI@cmpxchg.org> (raw)
In-Reply-To: <1635133586-84611-1-git-send-email-liuxp11@chinatelecom.cn>
On Mon, Oct 25, 2021 at 11:46:25AM +0800, Liu Xinpeng wrote:
> Comment in function psi_task_switch,there are two same lines.
> ...
> * runtime state, the cgroup that contains both tasks
> * runtime state, the cgroup that contains both tasks
> ...
>
> Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Peter, could you please take this through -tip?
> ---
> kernel/sched/psi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 1652f2b..526af84 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -833,7 +833,6 @@ void psi_task_switch(struct task_struct *prev, struct task_struct *next,
> /*
> * When switching between tasks that have an identical
> * runtime state, the cgroup that contains both tasks
> - * runtime state, the cgroup that contains both tasks
> * we reach the first common ancestor. Iterate @next's
> * ancestors only until we encounter @prev's ONCPU.
> */
next prev parent reply other threads:[~2021-11-04 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 3:46 [PATCH 1/2] psi: Remove repeated verbose comment Liu Xinpeng
2021-10-25 3:46 ` [PATCH 2/2] psi: Add a missing SPDX license header Liu Xinpeng
2021-11-04 16:50 ` Johannes Weiner
2021-11-17 14:00 ` [tip: sched/core] " tip-bot2 for Liu Xinpeng
2021-11-04 16:49 ` Johannes Weiner [this message]
2021-11-09 9:14 ` [PATCH 1/2] psi: Remove repeated verbose comment Peter Zijlstra
2021-11-17 14:00 ` [tip: sched/core] " tip-bot2 for Liu Xinpeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYQPL4exZUP2eruI@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuxp11@chinatelecom.cn \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox