From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62F7BC433EF for ; Fri, 5 Nov 2021 22:47:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4746C60249 for ; Fri, 5 Nov 2021 22:47:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233978AbhKEWty (ORCPT ); Fri, 5 Nov 2021 18:49:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233159AbhKEWtu (ORCPT ); Fri, 5 Nov 2021 18:49:50 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 143F7C061714 for ; Fri, 5 Nov 2021 15:47:10 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id t11so11891757plq.11 for ; Fri, 05 Nov 2021 15:47:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OxUqrQOKE5rz2Yy9rGFxDjQ64K2p6FbsasTsNrHPkGY=; b=oaRJRNUL2SeshzXw5yVr3ynQ87l1WCM717Ekxc3C6L/t2VOi9zgkRI9+8hunUnhNY+ 0msWk0cT4U5n99XcAvfOnCW/Cj2ZMX0HW0XqYw2n2baHGwSd+r0BqxWkJGOeWPcRnCRJ aGUE41MrHdgdkXSuZ3EQC+Nz7d+IXcNkJOnIkO2KmNR4z/l2OZ+njSV5O6KHdT6aYcbY ZBYX46mufxAAXdVuydJSwdZH300owuXKd0BPFcE0losc9dPeXD5YZBGQd7shvZXvReSC fbYPmxHsrrO0XrCG7dBjkChiiU7yzvrnmtABfUE9sqKQXhaAjQsUhpgMl/hrIEon9BXC JUTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OxUqrQOKE5rz2Yy9rGFxDjQ64K2p6FbsasTsNrHPkGY=; b=j4c8WTizKLDidoSKkNFTSeDb1aPyA5/5YiUN0J7i2SKhAFctU/eayTrMOhGEs32/ON sqgbf7BKt3bWMPCdilwsCILt+DeA0z7SZbSfIBmdU8DoplA53uLvGsMIjOyJfH/BwzeY CQXAzoLA4To8dnR6y9ZK9Zj5dvyZxA+7S6xlSTnfRCPxDVHU2hCpXrRaVVJ10bOybDaQ rmx5YjaGxtVcX6nHND+Ze+Tneqp1kXybBWUgwrXLbv1GYpx+ZwUvZ5GqWxxwrvZFVbjC RoDMoX6IPO82HcZwSL99j4HbJdLvLxK7NfF5BxYPk94lgTuqX4LyB6uT2bR0X3FMWHI3 gilg== X-Gm-Message-State: AOAM532roUrtwg7uNDqiFy20+Lj6tY+/sQBlvxy3ubgqB3xKgaxWDE5x DiIWwXxfNV2u9FerYIsNpQszfKq5Of3Idg== X-Google-Smtp-Source: ABdhPJw/vX5xoimWxW7XMyz2ihPOstRLNm8ajQj2qZQu+nXqI+ZsbMHHvfcgSeq6uyqWjYEbfLauKQ== X-Received: by 2002:a17:902:db07:b0:141:ea12:218b with SMTP id m7-20020a170902db0700b00141ea12218bmr35627640plx.46.1636152429333; Fri, 05 Nov 2021 15:47:09 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id s2sm11157690pjs.56.2021.11.05.15.47.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Nov 2021 15:47:08 -0700 (PDT) Date: Fri, 5 Nov 2021 22:47:04 +0000 From: Sean Christopherson To: Peter Gonda Cc: kvm@vger.kernel.org, Marc Orr , David Rientjes , Brijesh Singh , Tom Lendacky , Paolo Bonzini , linux-kernel@vger.kernel.org Subject: Re: [PATCH V11 4/5] selftest: KVM: Add open sev dev helper Message-ID: References: <20211021174303.385706-1-pgonda@google.com> <20211021174303.385706-5-pgonda@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211021174303.385706-5-pgonda@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 21, 2021, Peter Gonda wrote: > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index 10a8ed691c66..06a6c04010fb 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -31,6 +31,19 @@ static void *align(void *x, size_t size) > return (void *) (((size_t) x + mask) & ~mask); > } > > +int open_path_or_exit(const char *path, int flags) > +{ > + int fd; > + > + fd = open(path, flags); > + if (fd < 0) { > + print_skip("%s not available (errno: %d)", path, errno); While you're here, can you add the strerror(errno) as well? There are some other enhancements I'd like to make as some failure modes are really annoying, e.g. if the max vCPUs test fails/skips due to ulimits, but printing the human friendly version is an easy one to pick off. > + exit(KSFT_SKIP); > + } > + > + return fd; > +} > + > /* > * Open KVM_DEV_PATH if available, otherwise exit the entire program. > * > @@ -42,16 +55,7 @@ static void *align(void *x, size_t size) > */ > static int _open_kvm_dev_path_or_exit(int flags) > { > - int fd; > - > - fd = open(KVM_DEV_PATH, flags); > - if (fd < 0) { > - print_skip("%s not available, is KVM loaded? (errno: %d)", > - KVM_DEV_PATH, errno); > - exit(KSFT_SKIP); > - } > - > - return fd; > + return open_path_or_exit(KVM_DEV_PATH, flags); > } > > int open_kvm_dev_path_or_exit(void) > diff --git a/tools/testing/selftests/kvm/lib/x86_64/svm.c b/tools/testing/selftests/kvm/lib/x86_64/svm.c > index 2ac98d70d02b..14a8618efa9c 100644 > --- a/tools/testing/selftests/kvm/lib/x86_64/svm.c > +++ b/tools/testing/selftests/kvm/lib/x86_64/svm.c > @@ -13,6 +13,8 @@ > #include "processor.h" > #include "svm_util.h" > > +#define SEV_DEV_PATH "/dev/sev" > + > struct gpr64_regs guest_regs; > u64 rflags; > > @@ -160,3 +162,14 @@ void nested_svm_check_supported(void) > exit(KSFT_SKIP); > } > } > + > +/* > + * Open SEV_DEV_PATH if available, otherwise exit the entire program. > + * > + * Return: > + * The opened file descriptor of /dev/sev. > + */ > +int open_sev_dev_path_or_exit(void) > +{ > + return open_path_or_exit(SEV_DEV_PATH, 0); > +} > -- > 2.33.0.1079.g6e70778dc9-goog >