From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E700C433EF for ; Sun, 7 Nov 2021 13:29:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 745A161359 for ; Sun, 7 Nov 2021 13:29:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235410AbhKGNcd (ORCPT ); Sun, 7 Nov 2021 08:32:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:58154 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232562AbhKGNcc (ORCPT ); Sun, 7 Nov 2021 08:32:32 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4A0116135A; Sun, 7 Nov 2021 13:29:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1636291789; bh=YCmyscBPE2QiNY5lczPW0ymEfeZm1GcFDgzFLHmfgzU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HYaKsAJsM+a/QQv+i3v3ymSr7ApffaAVQof64/ux4e6rFHdTfkOPUIatzByn1JdjV 1X9MpDLj64IfPrGqD0hebyWw/p3N4LwZGw2RdvmweezU8SjRBS+OxStdjy0lqiBwxA 5K3CJYrYowf8lt1w80ZY85Cp6FtR7ZwJSMAgNmPU= Date: Sun, 7 Nov 2021 14:29:47 +0100 From: Greg Kroah-Hartman To: "Fabio M. De Francesco" Cc: Larry Finger , Phillip Potter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: r8188eu: Use kzalloc() with GFP_ATOMIC in atomic context Message-ID: References: <20211101191847.6749-1-fmdefrancesco@gmail.com> <2389191.WthrnW1hFq@localhost.localdomain> <6109499.H5l3i5aCOD@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6109499.H5l3i5aCOD@localhost.localdomain> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 07, 2021 at 02:15:59PM +0100, Fabio M. De Francesco wrote: > On Sunday, November 7, 2021 1:38:35 PM CET Greg Kroah-Hartman wrote: > > On Sun, Nov 07, 2021 at 12:43:51PM +0100, Fabio M. De Francesco wrote: > > > On Monday, November 1, 2021 8:18:47 PM CET Fabio M. De Francesco wrote: > > > > Use the GFP_ATOMIC flag of kzalloc() with two memory allocation in > > > > report_del_sta_event(). This function is called while holding > spinlocks, > > > > therefore it is not allowed to sleep. With the GFP_ATOMIC type flag, > the > > > > allocation is high priority and must not sleep. > > > > > > > > This issue is detected by Smatch which emits the following warning: > > > > "drivers/staging/r8188eu/core/rtw_mlme_ext.c:6848 > report_del_sta_event() > > > > warn: sleeping in atomic context". > > > > > > > > After the change, the post-commit hook output the following message: > > > > "CHECK: Prefer kzalloc(sizeof(*pcmd_obj)...) over > > > > kzalloc(sizeof(struct cmd_obj)...)". > > > > > > > > According to the above "CHECK", use the preferred style in the first > > > > kzalloc(). > > > > > > > > Fixes: 79f712ea994d ("staging: r8188eu: Remove wrappers for kalloc() > and > > > kzalloc()") > > > > Signed-off-by: Fabio M. De Francesco > > > > --- > > > > > [...] > > > > Please let me know if there is something that prevents this patch to be > > > applied. I have no problem in changing / adding whatever it is needed. > > > > Nothing needs to be done, I am waiting for 5.16-rc1 to be released > > before I pick up this patch, and others that will be targeted for > > 5.16-final. Only then will I queue them up, as the automated email you > > should have gotten when you submitted the patch said would happen. > > > > Just relax, there is no rush here :) > > > > Oh, sorry Greg. There must be something that I haven't understand about the > development process... :( > > Obviously I agree that there is no rush here :) > > As I said, this morning I read git log and saw patches that seemed more > recent; thus I thought that was the case to ask. I just (wrongly) thought > that the v3 of the patch got unnoticed or dropped because of some requests > that I had missed. Be sure to notice what branch commits are being applied to. There are different branches for a reason :) thanks, greg k-h