Re: [PATCH] soc: ti: fix wkup_m3_rproc_boot_thread return type

Santosh Shilimkar
2021-11-05T16:18:21Z

> On Nov 5, 2021, at 12:51 AM, Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The wkup_m3_rproc_boot_thread() function uses a nonstandard prototype,
> which broke after Eric's recent cleanup:
>
> drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread':
> drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type]
> 429 | return 0;
> | ^
> drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here
> 416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Change it to the normal prototype as it should have been from the
> start.
>
> Fixes: 111e70490d2a ("exit/kthread: Have kernel threads return instead of calling do_exit")
> Fixes: cdd5de500b2c ("soc: ti: Add wkup_m3_ipc driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> —

Looks good to me. Thanks !!

Acked-by: Santosh Shilimkar <ssantosh@kernel.org>