Re: [RFC PATCH] software node: Skip duplicated software_node sysfs

Andy Shevchenko
2021-11-08T18:06:48Z

On Mon, Nov 08, 2021 at 11:07:53AM -0500, Qian Cai wrote:
> On 11/5/21 3:39 PM, Andy Shevchenko wrote:
> >> Andy, thanks for the pointers so far. I was able to trace
> >> set_primary_fwnode() and set_secondary_fwnode().
> >
> > Can you share the trace you have got?

...

> Then, here are the relevant outputs indicating that
> "808622B7:01" and "xhci-hcd.3.auto" have the same
> primary but different secondaries.

So, it confirms my theory if I'm not mistaken.

Btw, what you can do in this case is to switch to use fwnode_create_software
node and switch them in drd.c. It will be much much easier to achieve then
full kernel refactoring.

> [ 11.233280] KK set_secondary_fwnode dev name = 808622B7:01, fwnode = ffff000838618840
> [ 11.241846] KK parent = platform
> [ 11.245790] KK primary = ffff0008064b9010
> [ 11.259838] KK set_primary_fwnode dev name = (null), fwnode = ffff0008064b9010
> [ 11.267795] KK parent = 808622B7:01
> [ 11.272000] KK fwnode->dev = 808622B7:01
> [ 11.276636] KK secondary = ffff000838618840
> [ 11.680489] KK set_secondary_fwnode dev name = xhci-hcd.3.auto, fwnode = ffff000838325040
> [ 11.689406] KK parent = 808622B7:01
> [ 11.693916] KK primary = ffff0008064b9010
> [ 11.698763] sysfs: cannot create duplicate filename '/devices/platform/808622B7:01/xhci-hcd.3.auto/software_node'

--
With Best Regards,
Andy Shevchenko