Re: [PATCH RFT 1/3] blk-mq: Drop busy_iter_fn blk_mq_hw_ctx argument

Hannes Reinecke
2021-11-28T10:42:06Z

On 11/2/21 12:27 PM, John Garry wrote:
> The only user of blk_mq_hw_ctx blk_mq_hw_ctx argument is
> blk_mq_rq_inflight().
>
> Function blk_mq_rq_inflight() uses the hctx to find the associated request
> queue to match against the request. However this same check is already
> done in caller bt_iter(), so drop this check.
>
> With that change there are no more users of busy_iter_fn blk_mq_hw_ctx
> argument, so drop the argument.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
> block/blk-mq-tag.c | 2 +-
> block/blk-mq.c | 17 ++++++++---------
> include/linux/blk-mq.h | 3 +--
> 3 files changed, 10 insertions(+), 12 deletions(-)
>
Reviewed-by Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer