From: Joe Burton <jevburton@google.com>
To: Hou Tao <houtao1@huawei.com>
Cc: Joe Burton <jevburton.kernel@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, Petar Penkov <ppenkov@google.com>,
Stanislav Fomichev <sdf@google.com>
Subject: Re: [RFC PATCH v3 2/3] bpf: Add selftests
Date: Tue, 9 Nov 2021 18:17:08 +0000 [thread overview]
Message-ID: <YYq7JHdIAdc2bU55@google.com> (raw)
In-Reply-To: <98178f0f-ff43-b996-f78b-778f74b44a6b@huawei.com>
Thu, Nov 04, 2021 at 02:32:37PM +0800, Hou Tao wrote:
> In fentry__x64_sys_write(), you just do trigger updates to maps, so for the
> portability of the test
> (e.g. run-able for arm64)
Agreed that the test should be runnable on arm64. I haven't tested there
yet but I'll do that before sending out v4.
> and minimal dependency (e.g. don't depends on /tmp),
> why do you
> using nanosleep() and replacing fentry_x64_sys_write by
> tp/syscalls/sys_enter_nanosleep instead.
As written, the example actually modifies the return of write(), so I
don't think I can switch to tp/syscalls/* without significantly
reworking the example. To minimize the amount of reworking while
improving compatibility, how does this sound:
1. Add #ifdefs to support arm64
2. Instead of opening /tmp/map_trace_test_file, open /dev/null
Of course this isn't as portable as your proposal but I think it might
be an acceptable compromise.
Best,
Joe
next prev parent reply other threads:[~2021-11-09 18:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 2:14 [RFC PATCH v3 0/3] Introduce BPF map tracing capability Joe Burton
2021-11-02 2:14 ` [RFC PATCH v3 1/3] bpf: Add map tracing functions and call sites Joe Burton
2021-11-02 2:14 ` [RFC PATCH v3 2/3] bpf: Add selftests Joe Burton
2021-11-04 6:32 ` Hou Tao
2021-11-09 18:17 ` Joe Burton [this message]
2021-11-02 2:14 ` [RFC PATCH v3 3/3] bpf: Add real world example for map tracing Joe Burton
2021-11-03 0:12 ` [RFC PATCH v3 0/3] Introduce BPF map tracing capability Alexei Starovoitov
2021-11-03 17:29 ` Yonghong Song
2021-11-03 17:45 ` Joe Burton
2021-11-03 17:49 ` Alexei Starovoitov
2021-11-04 4:23 ` Yonghong Song
2021-11-04 4:27 ` Alexei Starovoitov
2021-11-04 16:14 ` Alexei Starovoitov
2021-11-04 17:11 ` Yonghong Song
2021-11-03 10:34 ` Jamal Hadi Salim
2021-11-03 17:12 ` Joe Burton
2021-11-04 10:59 ` Jamal Hadi Salim
2021-11-04 11:08 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYq7JHdIAdc2bU55@google.com \
--to=jevburton@google.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=houtao1@huawei.com \
--cc=jevburton.kernel@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ppenkov@google.com \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox