public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Vihas Mak <makvihas@gmail.com>
Cc: sudipm.mukherjee@gmail.com, arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: ppdev: fixed a validation issue
Date: Tue, 9 Nov 2021 16:41:45 +0100	[thread overview]
Message-ID: <YYqWuYK/c6D9K3Xi@kroah.com> (raw)
In-Reply-To: <CAH1kMwR7BA6kpcHCmEnEQ_EPeJxFDHQ3QB9mAn0D8NzdB8LNhw@mail.gmail.com>

On Tue, Nov 09, 2021 at 09:04:57PM +0530, Vihas Mak wrote:
> > What happens today if the mode is not set properly?  Will the code paths
> > error out eventually, or will the call succeed?  The problem is that
> > there might be code that is working today that would break with a change
> > like this, as again, this is a very old driver.
> 
> I see. So I guess this driver might be better off without any changes,
> as new changes might break things more severely.

Changes in behavior always have the ability to break things.  What other
changes do you want to make to this old driver that might cause
problems?

And you didn't answer my question above, what happens if the mode is not
set properly today?

thanks,

greg k-h

  reply	other threads:[~2021-11-09 15:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 18:58 [PATCH] char: ppdev: fixed a validation issue Vihas Mak
2021-11-09  6:25 ` Greg KH
2021-11-09 10:41   ` Vihas Mak
2021-11-09 11:23     ` Greg KH
2021-11-09 15:34       ` Vihas Mak
2021-11-09 15:41         ` Greg KH [this message]
2021-11-09 17:51           ` Vihas Mak
2021-11-09 17:55             ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYqWuYK/c6D9K3Xi@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=makvihas@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox