Re: [PATCH] mm: fix panic in __alloc_pages

Michal Hocko
2021-11-02T11:44:49Z

On Tue 02-11-21 12:00:57, David Hildenbrand wrote:
> On 02.11.21 11:34, Alexey Makhalov wrote:
[...]
> >> The node onlining logic when onlining a CPU sounds bogus as well: Let's
> >> take a look at try_offline_node(). It checks that:
> >> 1) That no memory is *present*
> >> 2) That no CPU is *present*
> >>
> >> We should online the node when adding the CPU ("present"), not when
> >> onlining the CPU.
> >
> > Possible.
> > Assuming try_online_node was moved under add_cpu(), let’s
> > take look on this call stack:
> > add_cpu()
> > try_online_node()
> > __try_online_node()
> > hotadd_new_pgdat()
> > At line 1190 we'll have a problem:
> > 1183 pgdat = NODE_DATA(nid);
> > 1184 if (!pgdat) {
> > 1185 pgdat = arch_alloc_nodedata(nid);
> > 1186 if (!pgdat)
> > 1187 return NULL;
> > 1188
> > 1189 pgdat->per_cpu_nodestats =
> > 1190 alloc_percpu(struct per_cpu_nodestat);
> > 1191 arch_refresh_nodedata(nid, pgdat);
> >
> > alloc_percpu() will go for all possible CPUs and will eventually end up
> > calling alloc_pages_node() trying to use subject nid for corresponding CPU
> > hitting the same state #2 problem as NODE_DATA(nid) is still NULL and nid
> > is not yet online.
>
> Right, we will end up calling pcpu_alloc_pages()->alloc_pages_node() for
> each possible CPU. We use cpu_to_node() to come up with the NID.

Shouldn't this be numa_mem_id instead? Memory less nodes are odd little
critters crafted into the MM code without wider considerations. From
time to time we are struggling with some fallouts but the primary thing
is that zonelists should be valid for all memory less nodes. If that is
not the case then there is a problem with the initialization code. If
somebody is providing a bogus node to allocate from then this should be
fixed. It is still not clear to me which case are we hitting here.

--
Michal Hocko
SUSE Labs