From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B86C433F5 for ; Tue, 9 Nov 2021 23:46:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53D0D61027 for ; Tue, 9 Nov 2021 23:46:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229999AbhKIXtL (ORCPT ); Tue, 9 Nov 2021 18:49:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229845AbhKIXtI (ORCPT ); Tue, 9 Nov 2021 18:49:08 -0500 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF1EDC0613F5 for ; Tue, 9 Nov 2021 15:46:20 -0800 (PST) Received: by mail-pf1-x42e.google.com with SMTP id y5so939415pfb.4 for ; Tue, 09 Nov 2021 15:46:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6chuTYfgRvTDMG+7/4r5PAEJkXMffm8xsv4fOhQYrHg=; b=padV+5xbNxU2BtdwvYLqgobnJgC7jdztrJVhn7K2+WlRuLp3u+7Em538emsInI8ZW0 EzZn9v91Us4jfHf9Lmmw5fjJNJZXyPueYr0bLHlmaEwNiw9/mnseW7q3iUQMF0MSrqY7 fh/rdp+bFUiYM2Q6wMsioJo1q+LB3h94uhn4IoA8l8Oi2FnmukHc/WcnpMyQdwGZgNcX quegTOwOZXl16pimaWjp8HrU55UW3cRaxZ+73lXvIy+5zw7YWqG84GnZJq4QA8qj+lfZ 30vSgeoxKWa3Pm11ldKt4T1NH7NtZdcF3NNQhyDYYMuoCBmAmEhAxO9jY6+vIZP5JAti sSrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6chuTYfgRvTDMG+7/4r5PAEJkXMffm8xsv4fOhQYrHg=; b=rOoFoV2bYM6lCWQZzj6J1kIccPf+P/beD+Fi32bNfqj3WthN1aC190QXBTZv6etcWA i20w4WmjMzjtVVBXD5IOHbvEPyjyTLeKtWYxNMagOfqLvhlpYeTUXU4f+7SaVhiPg0LB 4hCUWuSs0MXicEnZLTYGHOCNCVaCBy6wR9WVuePWAvggR/b/B/UfG/CZVg66Fx1IE959 OsbqAFwihSLN5uIM7eBNVil3fHXfngqoV99jLuMlGtABwR1VuCq3qUJ+RLp635K4Gs+X oC1StfOgAv9tkhY3vZ3svF7AJADZdI9GGyE4Hi8RXFAo3r5KzOZ6LJ1I4k/NhSeSBvmi Rv2A== X-Gm-Message-State: AOAM53386sHHbVHs1diCZZwx+vAcgyu9AcPh6qrE/1wK4dnu1QW6TN4Y Rf7aZe1jYlGzzA75MUJe7Xt88g== X-Google-Smtp-Source: ABdhPJwm4B0oaMVW7WsgOG0J14c3t+T/mSfRgwMmqW6RiSnYPS/pCOwWjFlWP8+tiDx9Ql84OwTCuA== X-Received: by 2002:a65:6a47:: with SMTP id o7mr8900284pgu.439.1636501580110; Tue, 09 Nov 2021 15:46:20 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id y130sm14619421pfg.202.2021.11.09.15.46.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Nov 2021 15:46:19 -0800 (PST) Date: Tue, 9 Nov 2021 23:46:15 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Marc Zyngier , Guo Ren , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Boris Ostrovsky , Juergen Gross , Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Morse , Alexandru Elisei , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Artem Kashkanov , Like Xu , Zhu Lingshan Subject: Re: [PATCH v3 08/16] perf: Force architectures to opt-in to guest callbacks Message-ID: References: <20210922000533.713300-1-seanjc@google.com> <20210922000533.713300-9-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 22, 2021, Sean Christopherson wrote: > On Wed, Sep 22, 2021, Paolo Bonzini wrote: > > On 22/09/21 02:05, Sean Christopherson wrote: > > > @@ -1273,6 +1274,11 @@ static inline unsigned int perf_guest_handle_intel_pt_intr(void) > > > } > > > extern void perf_register_guest_info_callbacks(struct perf_guest_info_callbacks *cbs); > > > extern void perf_unregister_guest_info_callbacks(struct perf_guest_info_callbacks *cbs); > > > +#else > > > +static inline unsigned int perf_guest_state(void) { return 0; } > > > +static inline unsigned long perf_guest_get_ip(void) { return 0; } > > > +static inline unsigned int perf_guest_handle_intel_pt_intr(void) { return 0; } > > > +#endif /* CONFIG_GUEST_PERF_EVENTS */ > > > > Reviewed-by: Paolo Bonzini > > > > Having perf_guest_handle_intel_pt_intr in generic code is a bit off. Of > > course it has to be in the struct, but the wrapper might be placed in > > arch/x86/include/asm/perf_event.h as well (applies to patch 7 as well). > > Yeah, I went with this option purely to keep everything bundled together. I have > no strong opinion. Scratch, that, I do have an opinion. perf_guest_handle_intel_pt_intr() is in common code because the callbacks themselves and perf_get_guest_cbs() are defined in linux/perf_event.h, _after_ asm/perf_event.h is included. arch/x86/include/asm/perf_event.h is quite bereft of includes, so there's no obvious landing spot for those two things, and adding a new header seems like overkill.