From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D44C433F5 for ; Thu, 25 Nov 2021 16:43:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356388AbhKYQrA (ORCPT ); Thu, 25 Nov 2021 11:47:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:41746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237265AbhKYQo6 (ORCPT ); Thu, 25 Nov 2021 11:44:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E148361108; Thu, 25 Nov 2021 16:41:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637858506; bh=HEzFcPjpLIj3IF4Eia3OGUoygd6d8nC48bFgfzgmwAM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qQ23rWQktxNnZOoRQtqwV1AXo3X61oJAoaureYfgYRJy9EEv7uH87xC3/i1/3e+2D j56PabkZx/SqLA/tu1A9up38+u+f98MPZRp5R1Dk7nghyndKW2TjRdye3zYGU81YWI FYAAJ3nThm0bmcG3exxe8Hwqfnmwota64XT0AhIQ= Date: Thu, 25 Nov 2021 17:41:43 +0100 From: Greg KH To: Zameer Manji Cc: Larry Finger , Phillip Potter , Michael Straube , "Fabio M. De Francesco" , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: r8188eu: remove unused code in rtw_cmd.h Message-ID: References: <20211117143831.1511437-1-zmanji@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211117143831.1511437-1-zmanji@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 17, 2021 at 02:38:14PM +0000, Zameer Manji wrote: > This patch removes unused code in rtw_cmd.h. This is not really "code", it is something else. Please always be specific as to what you are doing and _WHY_ you are doing it. thanks, greg k-h