public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [GIT PULL] tracing/uprobe: Fix uprobe_perf_open probes iteration
Date: Wed, 24 Nov 2021 21:06:05 +0100	[thread overview]
Message-ID: <YZ6bLc81ZBeRUG+U@krava> (raw)
In-Reply-To: <CAHk-=whYWvdKrFY3-xcRFqyxAMnhMGsmU=0gYWYWuRrR7mFV-A@mail.gmail.com>

On Wed, Nov 24, 2021 at 10:30:24AM -0800, Linus Torvalds wrote:
> On Wed, Nov 24, 2021 at 10:27 AM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Instead, you should do something like
> >
> >         list_for_each_entry(pu, trace_probe_probe_list(tp), tp.list) {
> 
> That 'pu' is a typo, it should be 'tu'.
> 
> The patch itself got it right, I think.
> 
> HOWEVER. Despite the patch itself getting it right, I want to point
> out that that was mostly by luck than anything else.
> 
> The patch is ENTIRELY UNTESTED.

I put your patch to the test and.. it passed ;-)

there are several other places like this around and also in trace_kprobe.c
I can send the follow up fix tomorrow

thanks,
jirka

> 
> Because that's how I roll, as you should all know by now.
> 
>                   Linus
> 


  reply	other threads:[~2021-11-24 20:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 15:09 [GIT PULL] tracing/uprobe: Fix uprobe_perf_open probes iteration Steven Rostedt
2021-11-24 18:27 ` Linus Torvalds
2021-11-24 18:30   ` Linus Torvalds
2021-11-24 20:06     ` Jiri Olsa [this message]
2021-11-24 18:33   ` Steven Rostedt
2021-11-24 18:31 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZ6bLc81ZBeRUG+U@krava \
    --to=jolsa@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox