* [PATCH] dmaengine: ppc4xx: remove unused variable `rval'
@ 2021-11-14 6:08 Jason Wang
2021-11-25 5:18 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2021-11-14 6:08 UTC (permalink / raw)
To: vkoul; +Cc: salah.triki, wangborong, dmaengine, linux-kernel
The variable used for returning status in
`ppc440spe_adma_dma2rxor_prep_src' function is never changed
and this function just need to return 0. Thus, the `rval' can
be removed and return 0 from `ppc440spe_adma_dma2rxor_prep_src'.
Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
drivers/dma/ppc4xx/adma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c
index e2b5129c5f84..5e46e347e28b 100644
--- a/drivers/dma/ppc4xx/adma.c
+++ b/drivers/dma/ppc4xx/adma.c
@@ -3240,7 +3240,6 @@ static int ppc440spe_adma_dma2rxor_prep_src(
struct ppc440spe_rxor *cursor, int index,
int src_cnt, u32 addr)
{
- int rval = 0;
u32 sign;
struct ppc440spe_adma_desc_slot *desc = hdesc;
int i;
@@ -3348,7 +3347,7 @@ static int ppc440spe_adma_dma2rxor_prep_src(
break;
}
- return rval;
+ return 0;
}
/**
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: ppc4xx: remove unused variable `rval'
2021-11-14 6:08 [PATCH] dmaengine: ppc4xx: remove unused variable `rval' Jason Wang
@ 2021-11-25 5:18 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-11-25 5:18 UTC (permalink / raw)
To: Jason Wang; +Cc: salah.triki, dmaengine, linux-kernel
On 14-11-21, 14:08, Jason Wang wrote:
> The variable used for returning status in
> `ppc440spe_adma_dma2rxor_prep_src' function is never changed
> and this function just need to return 0. Thus, the `rval' can
> be removed and return 0 from `ppc440spe_adma_dma2rxor_prep_src'.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-25 5:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-14 6:08 [PATCH] dmaengine: ppc4xx: remove unused variable `rval' Jason Wang
2021-11-25 5:18 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox