From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Wang, Lawrence (NSB - CN/Hangzhou)" <lawrence.wang@nokia-sbell.com>
Cc: "jarkko.nikula@linux.intel.com" <jarkko.nikula@linux.intel.com>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Wang@wrlinb193.emea.nsn-net.net"
<Wang@wrlinb193.emea.nsn-net.net>
Subject: Re: [PATCH] i2c: designware: Get HCNT/LCNT values from dts
Date: Mon, 15 Nov 2021 13:01:46 +0200 [thread overview]
Message-ID: <YZI+Gq06wk9Xfk6v@smile.fi.intel.com> (raw)
In-Reply-To: <587c61a76c8547d0a36dd11071bfcb2d@nokia-sbell.com>
On Mon, Nov 15, 2021 at 10:41:06AM +0000, Wang, Lawrence (NSB - CN/Hangzhou) wrote:
Please, do not top post!
> Besides the fact it misses DT schema update, why this is needed at all?
> ------> we need a interface to configure the HCNT/LCNT via dts (current we just have ACPI to config it).
> What's wrong with the existing DT timings?
> --------> the HCNT/LCNT value calculated by code is not accuracy. This is similar changes as the ACPI interface.
So, _this_ is a problem, try to fix it instead of band aiding here and there.
P.S. You forgot to include proper people in the Cc list. I recommend to
consider using my script [1] for sending patches.
[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-15 11:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 9:35 [PATCH] i2c: designware: Get HCNT/LCNT values from dts Lawrence,Wang
2021-11-15 10:19 ` Andy Shevchenko
2021-11-15 10:28 ` Andy Shevchenko
2021-11-15 10:41 ` Wang, Lawrence (NSB - CN/Hangzhou)
2021-11-15 11:01 ` Andy Shevchenko [this message]
2021-11-16 1:43 ` Wang, Lawrence (NSB - CN/Hangzhou)
2021-11-29 19:28 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZI+Gq06wk9Xfk6v@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Wang@wrlinb193.emea.nsn-net.net \
--cc=jarkko.nikula@linux.intel.com \
--cc=lawrence.wang@nokia-sbell.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox