From: Greg KH <gregkh@linuxfoundation.org>
To: Alberto Merciai <alb3rt0.m3rciai@gmail.com>
Cc: devel@driverdev.osuosl.org, forest@alittletooquiet.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: vt6655: fix camelcase in wCurrentRate
Date: Mon, 15 Nov 2021 10:31:12 +0100 [thread overview]
Message-ID: <YZIo4HLyJ0TLT1I7@kroah.com> (raw)
In-Reply-To: <20211114090935.GA120704@t470p>
On Sun, Nov 14, 2021 at 10:09:35AM +0100, Alberto Merciai wrote:
> Replace camelcase word variable "wCurrentRate" into linux kernel coding
> style equivalent "current_rate".
>
> References:
> https://www.kernel.org/doc/html/latest/process/coding-style.html
We all know the kernel coding style, no need to have a link to it in the
changelog text, right?
> https://www.cse.iitk.ac.in/users/dsrkg/cs245/html/Guide.htm
Why is this here? That's a random college course web site.
And random links in changelog text do not age well, include the full
text of what matters in the changelog text itself, it should be
self-contained where ever possible as these live much longer than random
web site links will.
thanks,
greg k-h
prev parent reply other threads:[~2021-11-15 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 9:09 [PATCH v3] staging: vt6655: fix camelcase in wCurrentRate Alberto Merciai
2021-11-15 9:31 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZIo4HLyJ0TLT1I7@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alb3rt0.m3rciai@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox